[Dashboard] Replace twitter icon #4817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
This was referenced Sep 26, 2024
Contributor
Author
Contributor
size-limit report 📦
|
MananTank
reviewed
Sep 27, 2024
| import { DiscordIcon } from "components/icons/brand-icons/DiscordIcon"; | ||
| import { GithubIcon } from "components/icons/brand-icons/GithubIcon"; | ||
| import { XIcon } from "components/icons/brand-icons/XIcon"; | ||
| import type { ProfileMetadata } from "constants/schemas"; |
MananTank
approved these changes
Sep 27, 2024
kien-ngo
force-pushed
the
kien/replace-discord-icon
branch
from
37a2793 to
30a9e87
Compare
kien-ngo
force-pushed
the
kien/replace-twitter-icon
branch
from
3c8b546 to
c8745ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
=======================================
Coverage 47.67% 47.67%
=======================================
Files 1051 1051
Lines 56715 56715
Branches 3894 3894
=======================================
Hits 27040 27040
Misses 28988 28988
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
MananTank
force-pushed
the
kien/replace-discord-icon
branch
from
30a9e87 to
246439f
Compare
MananTank
force-pushed
the
kien/replace-twitter-icon
branch
from
c8745ff to
814ce6c
Compare
jnsdls
changed the base branch from
kien/replace-discord-icon
to
graphite-base/4817
Contributor
Merge activity
|
kien-ngo
force-pushed
the
kien/replace-twitter-icon
branch
from
814ce6c to
60beea0
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new `XIcon` component and replaces existing Twitter icons in various components with this new icon, enhancing consistency and potentially improving the visual design.
### Detailed summary
- Added a new `XIcon` component in `XIcon.tsx`.
- Replaced `SiTwitter` icon with `XIcon` in:
- `edit-profile.tsx`
- `socialLinks.tsx`
- `PublisherSocials.tsx`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/replace-twitter-icon
branch
from
60beea0 to
ffcd199
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing the usage of the
SiTwittericon with a customXIconcomponent across multiple files, enhancing consistency and potentially allowing for better customization.Detailed summary
XIconcomponent inapps/dashboard/src/components/icons/brand-icons/XIcon.tsx.SiTwittericon withXIconin:apps/dashboard/src/components/contract-components/publisher/edit-profile.tsxapps/dashboard/src/components/footer/socialLinks.tsxapps/dashboard/src/components/contract-components/publisher/PublisherSocials.tsx