fix(http): cap standard retry delays - #262
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep coverage instrumentation initialization outside the measured Current-read loop.
thomhurst
force-pushed
the
issue-217-retry-after-budget
branch
from
August 24, 2026 21:57
320bba1 to
fc18251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetryOptions.MaxDelayHttpShield.RetryAfter(TimeSpan maxDelay)for custom server-suggestion caps without shortening a larger computed backoffThe issue allows either a bounded delay or returning the response early. This uses the bounded-delay path because the current retry contract has no safe stop-and-retain-result sentinel; adding one would broaden into the retry-control work tracked separately.
Validation
dotnet build Kevlar.slnx -c Releasedotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m(850 passed)dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m(131 passed)dotnet run --project tests/Kevlar.NetStandard.Tests -c Release --no-build -- --timeout 5m(10 passed)dotnet run --project tests/Kevlar.NetStandard21.Tests -c Release --no-build -- --timeout 5m(4 passed)pwsh scripts/Verify-Docs.ps1pwsh scripts/Verify-DocSnippets.ps1 -PackagesPath artifacts/package/release -Version 0.0.0-docs217(119 snippets; behavior passed)npm ci --prefix docsnpm run build --prefix docsDepends on #258, whose repair commits are included in this branch.
Closes #217