fix(tests): use FallbackTo in new tests - #258
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
scripts/Verify-Packages.ps1:L67: 🔴 bug: Get-ExpectedSymbolAssets omits netstandard2.1 for Kevlar.Extensions.Grpc, so Ubuntu Verify-Packages fails after Pack. Append netstandard2.1 for that package; isolated local gate reproduces the exact expected-two/got-three PDB error. |
|
tests/Kevlar.Tests/ReloadingShieldTests.cs:L277: 🔴 bug: Provider_Current_Read_Does_Not_Allocate runs inside the Coverage job; instrumentation adds 376 bytes, failing both #258 and #260. Move this assertion to Kevlar.AllocationTests (or exclude an allocation category from coverage) so zero-allocation measurement runs only uninstrumented. |
Keep coverage instrumentation initialization outside the measured Current-read loop.
49628a9 to
b629dbe
Compare
Summary
Validation