Skip to content

fix(tests): use FallbackTo in new tests - #258

Merged
thomhurst merged 1 commit into
mainfrom
fix-main-fallback-tests
Aug 24, 2026
Merged

fix(tests): use FallbackTo in new tests#258
thomhurst merged 1 commit into
mainfrom
fix-main-fallback-tests

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • update newly merged typed-builder tests to call the renamed constant-value FallbackTo API
  • restore the full solution build after concurrent merges

Validation

  • dotnet build Kevlar.slnx -c Release
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m (845 passed)

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cdc1d50-a335-4860-9875-9dee97d7b2f7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thomhurst

Copy link
Copy Markdown
Owner Author

scripts/Verify-Packages.ps1:L67: 🔴 bug: Get-ExpectedSymbolAssets omits netstandard2.1 for Kevlar.Extensions.Grpc, so Ubuntu Verify-Packages fails after Pack. Append netstandard2.1 for that package; isolated local gate reproduces the exact expected-two/got-three PDB error.

@thomhurst

Copy link
Copy Markdown
Owner Author

tests/Kevlar.Tests/ReloadingShieldTests.cs:L277: 🔴 bug: Provider_Current_Read_Does_Not_Allocate runs inside the Coverage job; instrumentation adds 376 bytes, failing both #258 and #260. Move this assertion to Kevlar.AllocationTests (or exclude an allocation category from coverage) so zero-allocation measurement runs only uninstrumented.

Keep coverage instrumentation initialization outside the measured Current-read loop.
@thomhurst
thomhurst force-pushed the fix-main-fallback-tests branch from 49628a9 to b629dbe Compare August 24, 2026 21:57
@thomhurst
thomhurst merged commit da1431d into main Aug 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant