Skip to content

fix(handling): exclude fail-fast errors - #268

Merged
thomhurst merged 3 commits into
mainfrom
issue-215-default-handling
Aug 24, 2026
Merged

fix(handling): exclude fail-fast errors#268
thomhurst merged 3 commits into
mainfrom
issue-215-default-handling

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Closes #215.

What changed

  • exclude cancellation, circuit/rate/concurrency rejections, and fatal runtime exceptions from default reactive handling
  • preserve explicit opt-in clauses and ordinary/programming-error compatibility
  • add KEV011 informational guidance for implicit default handling
  • extend deterministic retry model and runtime/analyzer regression coverage
  • document the exact default and Polly migration difference

Depends on #258.

Validation

  • dotnet build Kevlar.slnx -c Release
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m (851 passed)
  • dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m (131 passed)
  • dotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5m (81 passed)
  • pwsh scripts/Verify-Docs.ps1
  • pwsh scripts/Verify-DocSnippets.ps1 -PackagesPath artifacts/package/release -Version 0.0.0-issue215 (122 snippets)
  • npm run build

Benchmark

RetryBenchmarks.Kevlar_Recovery ShortRun: 2.213 us / 192 B before; 2.093 us / 192 B after.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b03bcdfc-c0be-4579-ab2b-ea367d50c670


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4b844dfe1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Analyzers/PipelineHazardAnalyzer.cs Outdated
@thomhurst
thomhurst force-pushed the issue-215-default-handling branch from 2598444 to 21aa677 Compare August 24, 2026 21:57
@thomhurst
thomhurst merged commit 53b48ec into main Aug 24, 2026
9 checks passed
@thomhurst
thomhurst deleted the issue-215-default-handling branch August 24, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(handling): default clause should not retry Kevlar's own rejections (CircuitOpenException etc.) or fatal exceptions

1 participant