build: pin assembly identity policy - #271
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4666df7 to
5156544
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5156544a30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep AssemblyVersion stable within each package major while preserving floating file and informational versions. Strong naming remains deliberately disabled because the netstandard core depends on unsigned Reservoir. Closes #188
5156544 to
89f1cd2
Compare
1 participant
Closes #188.
Decision
Kevlar remains intentionally unsigned for 1.x.
Reservoir1.4.0 is unsigned, and .NET Framework strong naming is viral: signing Kevlar while retaining that dependency is not a valid supported configuration. The limitation and major-release migration boundary are now explicit in the library-author docs.Behavior
AssemblyVersionto<package-major>.0.0.0FileVersionat the numeric package versionInformationalVersionat full SemVer plus commitMicrosoft guidance: https://learn.microsoft.com/dotnet/standard/library-guidance/strong-naming
Validation
dotnet build Kevlar.slnx -c Release -p:Version=1.2.3-alpha.4 -p:CI=truepwsh scripts/Verify-Docs.ps1npm run buildindocs/