Always move test outs even if there are test args or failures#3550
Merged
Conversation
In the test step there is a `moveAndCacheOutputFiles` local function that's called if all test cases succeed. It exits early if any arguments were passed to the test, with the stated reason being that results shouldn't be cached if args were passed. The problem is that while it does prevent caching, it also prevents the files being copied to the output dir. This is unhelpful because those output files are not invalidated by the passing of args, indeed sometimes arguments are passed precisely //so// they are produced. Those files can also be helpful in diagnosing failures. This diff refactors the helpers to separate moving output files from the caching: files are always moved even when there are failures, but the original checks are still there and do prevent those files being cached.
chris-franklin
marked this pull request as ready for review
July 21, 2026 12:30
toastwaffle
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test step there is a
moveAndCacheOutputFileslocal function that's called if all test cases succeed. It exits early if any arguments were passed to the test, with the stated reason being that results shouldn't be cached if args were passed.The problem is that while it does prevent caching, it also prevents the files being moved to the output dir. This is unhelpful because those output files are not invalidated by the passing of args, indeed sometimes arguments are passed precisely so they are produced. Those files can also be helpful in diagnosing failures.
This diff refactors the helpers to separate moving output files from the caching: files are always moved even when there are failures, but the original checks are still there and do prevent those files being cached. Moving the test results file is still kept behind the check because Please treats it as a cache of test results.