Add migration styles by jessieay · Pull Request #159 · thoughtbot/guides

jessieay · 2014-04-16T21:32:04Z

Default non-presence-validated string fields to empty string to avoid nil values
Put timestamps at the top when creating a table for consistency

Screenshot of db/schema with consistent use of timestamps at top:

Screenshot of db/schema without consistent use of timestamps at top:

croaky · 2014-04-16T21:38:04Z

Periods at the end of sentences.

Maybe "List timestamps first when creating a new table."

Link to an example migration?

done and done!

croaky · 2014-04-16T21:38:09Z

+1

gylaz · 2014-04-16T22:13:03Z

It would be useful to add the default: '' example to the migrations file.

richrines · 2014-04-16T22:16:11Z

@gylaz I like the default: '' only on fields that are not null: false. That might just be personal preference.

jessieay · 2014-04-16T22:17:18Z

@gylaz @richrines added a non-required field to the migration and added a default: '' to it :)

gylaz · 2014-04-16T22:19:23Z

Why did these change?

there was whitespace so I removed it and added it back to one line while I was at it. Are you going to make me take it back!? 😱

You can just put it on one line. It fits under 80 characters.

* Default non-presence-validated string fields to empty string to avoid nil values * Put timestamps at the top when creating a table for consistency

jessieay · 2014-04-17T17:19:47Z

@jferris any input on this?

jferris · 2014-04-17T17:21:44Z

Should this say "default value?"

I'm not sure but DEFAULT Constraint is a term. Maybe "Set an empty string as the default constraint value" would be more correct?

Hmm, it seems like "default constraint" is actually the correct terminology here. Sort of confusing, because "default constraint" doesn't make much sense in English, but I'd say stick with the correct term according to SQL.

jferris · 2014-04-17T17:22:25Z

Looks good to me! I had one question on verbiage.

`rails generate` puts timestamps at the bottom of a migration by default, meaning we have to change every migration even if the migration is otherwise generated perfectly. Original discussion: #159

`rails generate` puts timestamps at the bottom of a migration by default, meaning we have to change every migration even if the migration is otherwise generated perfectly. Original discussion: thoughtbot/guides#159

croaky reviewed Apr 16, 2014
View reviewed changes

gylaz reviewed Apr 16, 2014
View reviewed changes

Add migration styles

2344338

* Default non-presence-validated string fields to empty string to avoid nil values * Put timestamps at the top when creating a table for consistency

jferris reviewed Apr 17, 2014
View reviewed changes

jessieay merged commit 2344338 into master Apr 17, 2014

jessieay deleted the jy-add-migration-styles branch April 17, 2014 17:45

gabebw mentioned this pull request Jan 15, 2015

Do not put timestamps at the top of a migration #288

Merged

Uh oh!

Conversation

jessieay commented Apr 16, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

croaky commented Apr 16, 2014

Uh oh!

gylaz commented Apr 16, 2014

Uh oh!

richrines commented Apr 16, 2014

Uh oh!

jessieay commented Apr 16, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jessieay commented Apr 17, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jferris commented Apr 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants