Skip to content
This repository was archived by the owner on Mar 2, 2018. It is now read-only.

Prevent background scroll for modal#221

Merged
teoljungberg merged 1 commit intomasterfrom
mg-modal-background-scroll
Jan 22, 2015
Merged

Prevent background scroll for modal#221
teoljungberg merged 1 commit intomasterfrom
mg-modal-background-scroll

Conversation

@teoljungberg
Copy link
Copy Markdown
Contributor

Closes #37

@teoljungberg teoljungberg force-pushed the mg-modal-background-scroll branch from c17c802 to 67c5662 Compare January 22, 2015 09:58
@Magnus-G
Copy link
Copy Markdown
Contributor

@teoljungberg very nice! Just one comment.

Comment thread source/stylesheets/refills/_modal.scss Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move these to the bottom of the file, just above the credit

@teoljungberg teoljungberg force-pushed the mg-modal-background-scroll branch from 67c5662 to 27dd74b Compare January 22, 2015 16:02
@teoljungberg
Copy link
Copy Markdown
Contributor Author

Thanks @Magnus-G, merging

@teoljungberg teoljungberg merged commit 27dd74b into master Jan 22, 2015
@teoljungberg teoljungberg deleted the mg-modal-background-scroll branch January 22, 2015 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modals - prevent background page scroll

2 participants