Enhance error handling in Dependants loader functions with user-facing error mapping #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Oksamies wants to merge 1 commit into 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping from 11-19-enhance_error_handling_in_dependants_loader_functions_with_user-facing_error_mapping

Contributor

Oksamies commented Nov 19, 2025

No description provided.

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 11-19-enhance_error_handling_in_dependants_loader_functions_with_user-facing_error_mapping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Contributor Author

Oksamies commented Nov 19, 2025 •

edited

Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

VilppeRiskidev approved these changes

View reviewed changes

Oksamies changed the base branch from 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping to graphite-base/1628

December 2, 2025 13:10

Oksamies force-pushed the graphite-base/1628 branch from cd40580 to 5ac0d36 Compare

December 2, 2025 13:15

Oksamies force-pushed the 11-19-enhance_error_handling_in_dependants_loader_functions_with_user-facing_error_mapping branch from 53f2970 to 81fe141 Compare

December 2, 2025 13:15

Oksamies changed the base branch from graphite-base/1628 to 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping

December 2, 2025 13:15


          Enhance error handling in Dependants loader functions with user-facin…

a6af81c

…g error mapping

Oksamies changed the base branch from 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping to graphite-base/1628

December 3, 2025 01:46

Oksamies force-pushed the graphite-base/1628 branch from 5ac0d36 to de2572f Compare

December 3, 2025 01:51

Oksamies force-pushed the 11-19-enhance_error_handling_in_dependants_loader_functions_with_user-facing_error_mapping branch from 81fe141 to a6af81c Compare

December 3, 2025 01:51

Oksamies changed the base branch from graphite-base/1628 to 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping

December 3, 2025 01:51

github-advanced-security bot found potential problems

View reviewed changes

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import { DapperTs } from "@thunderstore/dapper-ts";

              import "./Dependants.css";

              import { PackageSearch } from "~/commonComponents/PackageSearch/PackageSearch";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace PackageSearch·}·from·"~/commonComponents/PackageSearch/PackageSearch with handleLoaderError·}·from·"cyberstorm/utils/errors/handleLoaderError

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import { PackageSearch } from "~/commonComponents/PackageSearch/PackageSearch";

              import { PackageOrderOptions } from "../../commonComponents/PackageSearch/components/PackageOrder";

              import { type OutletContextShape } from "../../root";

              import { PageHeader } from "~/commonComponents/PageHeader/PageHeader";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace PageHeader·}·from·"~/commonComponents/PageHeader/PageHeader with getLoaderTools·}·from·"cyberstorm/utils/getLoaderTools

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

Comment on lines +12 to +15

    
              import {

                NimbusAwaitErrorElement,

                NimbusDefaultRouteErrorBoundary,

              } from "cyberstorm/utils/errors/NimbusErrorBoundary";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ⏎··NimbusAwaitErrorElement,⏎··NimbusDefaultRouteErrorBoundary,⏎}·from·"cyberstorm/utils/errors/NimbusErrorBoundary with ·parseIntegerSearchParam·}·from·"cyberstorm/utils/searchParamsUtils

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              } from "cyberstorm/utils/errors/NimbusErrorBoundary";

              import type { Route } from "./+types/Dependants";

              import "./Dependants.css";

              import { Suspense } from "react";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace Suspense·}·from·"react with Await,·useLoaderData,·useOutletContext·}·from·"react-router

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import type { Route } from "./+types/Dependants";

              import "./Dependants.css";

              import { Suspense } from "react";

              import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace throwUserFacingPayloadResponse·}·from·"cyberstorm/utils/errors/userFacingErrorResponse with PackageSearch·}·from·"~/commonComponents/PackageSearch/PackageSearch

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import "./Dependants.css";

              import { Suspense } from "react";

              import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";

              import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace handleLoaderError·}·from·"cyberstorm/utils/errors/handleLoaderError"; with PageHeader·}·from·"~/commonComponents/PageHeader/PageHeader";⏎

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import { Suspense } from "react";

              import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";

              import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";

              import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ·createNotFoundMapping·}·from·"cyberstorm/utils/errors/loaderMappings"; with ⏎··NewLink,⏎··SkeletonBox,⏎··formatToDisplayName,⏎}·from·"@thunderstore/cyberstorm";⏎

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";

              import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";

              import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";

              import { getLoaderTools } from "cyberstorm/utils/getLoaderTools";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace getLoaderTools·}·from·"cyberstorm/utils/getLoaderTools with PackageOrderOptions·}·from·"../../commonComponents/PackageSearch/components/PackageOrder

apps/cyberstorm-remix/app/p/dependants/Dependants.tsx

    
              import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";

              import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";

              import { getLoaderTools } from "cyberstorm/utils/getLoaderTools";

              import { parseIntegerSearchParam } from "cyberstorm/utils/searchParamsUtils";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace parseIntegerSearchParam·}·from·"cyberstorm/utils/searchParamsUtil with type·OutletContextShape·}·from·"../../root";⏎import·type·{·Route·}·from·"./+types/Dependants";⏎import·"./Dependants.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet