Refactor API methods to remove unnecessary async/await and improve return handling

[Oksamies]

Refactor API methods to remove unnecessary async/await and improve return handling

Note: Some of the functions return shapes differ as of this commit, so the places that use these functions should change in future commits

Update dapper-fake functions to match the changed dapper methods return shapes (pagination)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• (ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616 : 19 dependent PRs (#1617 , #1618 , #1619 and 16 others)
• Refactor API methods to remove unnecessary async/await and improve return handling #1615 👈 (View in Graphite)
• (thunderstore-api) Implement user-facing error handling improvements and update tests for authentication errors #1614
• Implement Nimbus error handling components and utilities for consistent user-facing error messages #1613
• chore: migrate build system to Vite and update TS config #1648
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[anttimaki]

Nothing to comment here except that the comment from previous PR's review applies here too.