chore: migrate build system to Vite and update TS config #1648

Oksamies · 2025-12-01T18:57:02Z

chore: migrate build system to Vite and update TS config

Migrate cyberstorm, cyberstorm-theme, and ts-uploader to use Vite for building.
Update root package.json to exclude Vite-built packages from Preconstruct and add explicit build steps.
Switch moduleResolution to bundler across all packages.
Add root tsconfig.json with project references.
Update types fields in package.json for various packages.
Add @babel/runtime dependency to multiple packages.

Run pre-commit on all files for sorting imports

coderabbitai · 2025-12-01T18:57:16Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 12-01-chore_migrate_build_system_to_vite_and_update_ts_config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Oksamies · 2025-12-01T18:57:22Z

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616 : 19 dependent PRs (#1617 , #1618 , #1619 and 16 others)
Refactor API methods to remove unnecessary async/await and improve return handling #1615
(thunderstore-api) Implement user-facing error handling improvements and update tests for authentication errors #1614
Implement Nimbus error handling components and utilities for consistent user-facing error messages #1613
chore: migrate build system to Vite and update TS config #1648 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR migrates the build system from Preconstruct to Vite for several packages (cyberstorm, cyberstorm-theme, ts-uploader) and standardizes TypeScript configurations across the monorepo. The migration includes updating module resolution settings, adding Prettier import sorting, and ensuring consistent build outputs.

Key changes:

Migration of build tooling from Preconstruct/TSC to Vite for three packages
TypeScript moduleResolution changed from node to bundler across all packages
Import sorting standardized via Prettier plugin
Updated types field in package.json files to point to source files

Reviewed changes

Copilot reviewed 300 out of 304 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/cyberstorm/vite.config.ts	New Vite configuration for cyberstorm package build
packages/cyberstorm-theme/vite.config.ts	New Vite configuration for cyberstorm-theme package build
packages/ts-uploader/vite.config.ts	New Vite configuration for ts-uploader package build
package.json	Updated build script to include Vite-built packages and excluded them from Preconstruct
.prettierrc	Added import sorting plugin configuration
Multiple tsconfig.json files	Changed moduleResolution from "node" to "bundler"
Multiple package.json files	Updated types field to point to source files and added @babel/runtime dependency
Multiple source files	Import statements reordered according to new Prettier rules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-01T19:04:31Z

packages/ts-api-react-actions/src/ApiAction.tsx

      } catch (e) {
        if (onSubmitError) {
-          onSubmitError(e);
+          onSubmitError(e as Error | ApiError);


Type assertion added to handle error parameter. While this fixes the type error, consider checking the error type with a type guard (e.g., isApiError(e)) before passing to onSubmitError to ensure type safety at runtime.

Copilot · 2025-12-01T19:04:32Z

apps/cyberstorm-remix/app/tools/manifest-validator/manifestValidator.tsx

-          return { value: team, label: team };
-        }
-        return { value: team.name, label: team.name };
+        return { value: team, label: team };


The code assumes team is a string, but the removed conditional suggests teams could be objects with a name property. This change may break if currentUser.teams contains objects instead of strings. Verify that the API always returns teams as strings, or restore the type checking.

Suggested change

return { value: team, label: team };

if (typeof team === "string") {

return { value: team, label: team };

} else if (team && typeof team === "object" && typeof team.name === "string") {

return { value: team.name, label: team.name };

} else {

return { value: "", label: "" };

}

Copilot · 2025-12-01T19:04:32Z

packages/thunderstore-api/tsconfig.json

    "experimentalDecorators": true,
    "resolveJsonModule": true,
    "forceConsistentCasingInFileNames": true,
+    "verbatimModuleSyntax": false,


Setting verbatimModuleSyntax to false is discouraged when using moduleResolution: bundler. Consider removing this option or setting it to true to ensure TypeScript's import/export statements are preserved as-is, which is the recommended practice with bundler module resolution.

Suggested change

"verbatimModuleSyntax": false,

Copilot · 2025-12-01T19:04:33Z

packages/thunderstore-api/package.json

+    "@babel/runtime": "^7.25.6",
+    "zod": "^3.23.8"


Moving zod from devDependencies to dependencies changes its role in the package. Verify that zod is actually used at runtime in consuming packages, as it may be sufficient as a devDependency if it's only used for type definitions and build-time validation.

- Migrate `cyberstorm`, `cyberstorm-theme`, and `ts-uploader` to use Vite for building. - Update root `package.json` to exclude Vite-built packages from Preconstruct and add explicit build steps. - Switch `moduleResolution` to `bundler` across all packages. - Add root `tsconfig.json` with project references. - Update `types` fields in `package.json` for various packages. - Add `@babel/runtime` dependency to multiple packages.

packages/cyberstorm/vite.config.ts

+
+import pkg from "./package.json";
+
+const { dependencies, peerDependencies } = pkg as any;


Roffenlund

I cannot build the project with the changes done in this PR. I get the following error:

[plugin:vite:import-analysis] Failed to resolve entry for package "@thunderstore/cyberstorm". The package may have incorrect main/module/exports specified in its package.json.

I tried running yarn install followed by yarn install --check-files in order to try and force a re-install. Not sure if this was the correct procedure, but it seemed to have the expected effect when switching back to the master branch.

Oksamies · 2025-12-03T15:45:28Z

I cannot build the project with the changes done in this PR. I get the following error:

[plugin:vite:import-analysis] Failed to resolve entry for package "@thunderstore/cyberstorm". The package may have incorrect main/module/exports specified in its package.json.

I tried running yarn install followed by yarn install --check-files in order to try and force a re-install. Not sure if this was the correct procedure, but it seemed to have the expected effect when switching back to the master branch.

Ah, ye, I'll take a look at it. It's probably the removal of preconstruct from few packages that creates this issue. Thanks for testing, I'll get back to this at some point.

Oksamies requested a review from Copilot December 1, 2025 19:03

Copilot AI reviewed Dec 1, 2025

View reviewed changes

Oksamies added 2 commits December 2, 2025 21:22

Run pre-commit on all files for sorting imports

19be637

Oksamies force-pushed the 12-01-chore_migrate_build_system_to_vite_and_update_ts_config branch from 0e9d28f to 19be637 Compare December 3, 2025 01:44

github-advanced-security bot found potential problems Dec 3, 2025

View reviewed changes

packages/cyberstorm/vite.config.ts

import pkg from "./package.json";

const { dependencies, peerDependencies } = pkg as any;

Check failure

Code scanning / ESLint

Disallow the `any` type Error

Unexpected any. Specify a different type.

Roffenlund requested changes Dec 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: migrate build system to Vite and update TS config #1648

chore: migrate build system to Vite and update TS config #1648

Uh oh!

Oksamies commented Dec 1, 2025

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

Oksamies commented Dec 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Check failure

Roffenlund left a comment

Uh oh!

Oksamies commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-        return { value: team, label: team };
+        if (typeof team === "string") {
+          return { value: team, label: team };
+        } else if (team && typeof team === "object" && typeof team.name === "string") {
+          return { value: team.name, label: team.name };
+        } else {
+          return { value: "", label: "" };
+        }


		import pkg from "./package.json";

		const { dependencies, peerDependencies } = pkg as any;

chore: migrate build system to Vite and update TS config #1648

Are you sure you want to change the base?

chore: migrate build system to Vite and update TS config #1648

Uh oh!

Conversation

Oksamies commented Dec 1, 2025

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

Oksamies commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Check failure

Roffenlund left a comment

Choose a reason for hiding this comment

Uh oh!

Oksamies commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Oksamies commented Dec 1, 2025 •

edited

Loading