Skip to content

Enhance error handling and user feedback across team settings routes with Suspense and Nimbus error boundaries #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping
Choose a base branch
from
Draft

Enhance error handling and user feedback across team settings routes with Suspense and Nimbus error boundaries #1633

wants to merge 1 commit into from

Conversation

@Oksamies
Copy link
Contributor

@Oksamies Oksamies commented Nov 19, 2025

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 11-19-enhance_error_handling_and_user_feedback_across_team_settings_routes_with_suspense_and_nimbus_error_boundaries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Oksamies Graphite App
Copy link
Contributor Author

Oksamies commented Nov 19, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Oksamies Oksamies changed the base branch from 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping to graphite-base/1633 December 2, 2025 13:10
@Oksamies Oksamies force-pushed the 11-19-enhance_error_handling_and_user_feedback_across_team_settings_routes_with_suspense_and_nimbus_error_boundaries branch from bd556b5 to f33adae Compare December 2, 2025 13:17
@Oksamies Oksamies changed the base branch from graphite-base/1633 to 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping December 2, 2025 13:17
@Oksamies Oksamies changed the base branch from 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping to graphite-base/1633 December 3, 2025 01:46
@Oksamies Oksamies force-pushed the 11-19-enhance_error_handling_and_user_feedback_across_team_settings_routes_with_suspense_and_nimbus_error_boundaries branch from f33adae to e89f0de Compare December 3, 2025 01:53
@Oksamies Oksamies changed the base branch from graphite-base/1633 to 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping December 3, 2025 01:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 3, 2025
View reviewed changes
apps/cyberstorm-remix/app/p/team/Team.tsx
import type { Route } from "./+types/Team";
import "./Team.css";
import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace handleLoaderError·}·from·"cyberstorm/utils/errors/handleLoaderError with getLoaderTools·}·from·"cyberstorm/utils/getLoaderTools
apps/cyberstorm-remix/app/p/team/Team.tsx
import "./Team.css";
import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";
import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace createNotFoundMapping·}·from·"cyberstorm/utils/errors/loaderMapping with parseIntegerSearchParam·}·from·"cyberstorm/utils/searchParamsUtil
apps/cyberstorm-remix/app/p/team/Team.tsx
import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";
import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";
import { SkeletonBox } from "@thunderstore/cyberstorm";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace keletonBox·}·from·"@thunderstore/cyberstorm with uspense·}·from·"react
apps/cyberstorm-remix/app/p/team/Team.tsx
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";
import { createNotFoundMapping } from "cyberstorm/utils/errors/loaderMappings";
import { SkeletonBox } from "@thunderstore/cyberstorm";
import { Suspense } from "react";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace Suspense·}·from·"react with Await,·useLoaderData,·useOutletContext·}·from·"react-router
apps/cyberstorm-remix/app/p/team/Team.tsx
Comment on lines +13 to +16
import {
NimbusAwaitErrorElement,
NimbusDefaultRouteErrorBoundary,
} from "cyberstorm/utils/errors/NimbusErrorBoundary";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ⏎··NimbusAwaitErrorElement,⏎··NimbusDefaultRouteErrorBoundary,⏎}·from·"cyberstorm/utils/errors/NimbusErrorBoundary"; with ·PackageSearch·}·from·"~/commonComponents/PackageSearch/PackageSearch";⏎import·{·PageHeader·}·from·"~/commonComponents/PageHeader/PageHeader";⏎⏎import·{·SkeletonBox·}·from·"@thunderstore/cyberstorm";⏎
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx
SkeletonBox,
useToast,
} from "@thunderstore/cyberstorm";
import {

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Insert type·{·DapperTs·}·from·"@thunderstore/dapper-ts";⏎import·
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx
Comment on lines +22 to +23
teamAddMember,
type TeamAddMemberRequestData,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete eamAddMember,⏎··t
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx
Comment on lines +24 to +25
teamRemoveMember,
UserFacingError,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete teamRemoveMember,⏎··
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx
teamRemoveMember,
UserFacingError,
formatUserFacingError,
} from "@thunderstore/thunderstore-api";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Insert ··teamAddMember,⏎··teamRemoveMember,⏎
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx
Comment on lines +30 to +32
import { type OutletContextShape } from "app/root";
import { makeTeamSettingsTabLoader } from "cyberstorm/utils/getLoaderTools";
import { useStrongForm } from "cyberstorm/utils/StrongForm/useStrongForm";

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace type·OutletContextShape·}·from·"app/root";⏎import·{·makeTeamSettingsTabLoader·}·from·"cyberstorm/utils/getLoaderTools";⏎import·{·useStrongForm·}·from·"cyberstorm/utils/StrongForm/useStrong with MemberAddForm·}·from·"./MemberAdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VilppeRiskidev VilppeRiskidev VilppeRiskidev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Oksamies @VilppeRiskidev