fix: normalize cache token usage semantics - #1390
Conversation
There was a problem hiding this comment.
Findings
- No actionable findings.
Summary
Review mode: initial
No correctness, security, regression, data-loss, performance, or maintainability issues were found in the modified lines. Residual risk: schema v21 reindexes historical usage using producer-shape heuristics, so a provider payload variant absent from the fixtures could still be misclassified.
Testing
- Not run (automation; PR content was not executed). GitHub
testcheck passed for head3fa9cae7.
HAPI Bot
Normalize usage input at parse time, mark inclusive producers, rebuild derived usage indexes, and preserve valid primary usage when cache partitions are malformed. Fixes tiann#1389
3fa9cae to
cb29000
Compare
There was a problem hiding this comment.
Findings
- No actionable findings.
Summary
Review mode: follow-up after new commits
No correctness, security, regression, data-loss, performance, or maintainability issues were found in the modified lines. Residual risk: cumulative reset handling and legacy input-semantics reconstruction still depend on provider-shaped historical fixtures; the current CI test check has not completed yet.
Testing
- Not run (automation; PR content was not executed). GitHub
testcheck is in progress for headcb29000d.
HAPI Bot
Absorb tiann#1376 session-summary hub toggle (opt-in) + tiann#1388/tiann#1390/tiann#1391. Keep soup Overseer/FUE/PR-awareness/runners on Settings → General. Co-authored-by: Cursor <cursoragent@cursor.com>
Rebase union onto tip-forward remat after upstream/main (tiann#1390 owns schema v21 usage semantics). Keep pin column as idempotent v21→v22. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Historical compatibility
modelproperty remain inclusiveValidation
bun run typecheckCloses #1389