Skip to content

fix(web): show truncated query on collapsed session search - #1391

Merged
tiann merged 2 commits into
tiann:mainfrom
heavygee:feat/session-search-collapsed-query
Aug 6, 2026
Merged

fix(web): show truncated query on collapsed session search#1391
tiann merged 2 commits into
tiann:mainfrom
heavygee:feat/session-search-collapsed-query

Conversation

@heavygee

@heavygee heavygee commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

After the session search collapsed into the sidebar toolbar (3f73a5f6e), an active text filter left only the search icon + indicator dot. Operators could see that a filter was active, but not for what.

This change renders a compact chip when collapsed with a text query:

  • Search icon + truncated query (truncate / ellipsis, max-w-[9rem])
  • Active highlight via --app-chat-user-chip-bg / --app-chat-user-chip-fg so the chip still reads as active when text truncates away at small widths
  • Click still expands to the full input
  • Keeps the standalone date-filter control from fix(web): keep session date filter directly accessible #1367

Test plan

  • Vitest: collapsed control shows query text + chip token classes
  • Vitest: expand / filter / blur still collapses and keeps filtering
  • bun run typecheck (web)
  • Hard-reload sessions sidebar: type a query (e.g. jellybot), blur — blue chip shows truncated text
  • Narrow the sidebar until text ellipsizes — blue wash still visible
  • Date-only filter (no text): standalone calendar control unchanged

Issues

Fixes #1356

heavygee and others added 2 commits August 6, 2026 04:42
Collapsed SessionListSearch only showed an indicator dot for active
filters, hiding the terms operators need. Render a compact truncated
query chip when text filter is set (Fixes tiann#1356).

Co-authored-by: Cursor <cursoragent@cursor.com>
--app-link/15 washes to near-gray in default light mode (link is
near-black). Use --app-chat-user-chip-* so the collapsed query chip
stays a visible blue highlight when text truncates away.

Co-authored-by: Cursor <cursoragent@cursor.com>
@heavygee

heavygee commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Dogfood proof on live soup: collapsed SessionListSearch shows truncated query with chat-user chip colors.

Collapsed search chip with jellybot (blue wash)

asset: heavygee/hapi@pr-attach-proof-1391/proof-2026-08-06T04-42-58-1356-soup-blue-chip-header.png · delete release after merge if desired

@heavygee

heavygee commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Proof (pr-attach-proof, release strategy — not user-attachments)

Collapsed query chip close-up

asset: heavygee/hapi@pr-attach-proof-1391/proof-2026-08-06T04-43-02-1356-soup-blue-chip.png · delete release after merge if desired

@heavygee heavygee added area:web Web PWA / React client low-impact Focused / low-blast-radius change; estate lane B promote candidate (PR merge policy) labels Aug 6, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • None.

Summary

  • Review mode: initial
  • No issues found in the added/modified lines. Residual risk: the real narrow-sidebar ellipsis/layout behavior is covered only by the PR’s manual test plan; the added jsdom test verifies text and classes, not rendered truncation.

Testing

  • Not run (automation)

HAPI Bot

@tiann
tiann merged commit 6ffc125 into tiann:main Aug 6, 2026
2 checks passed
@heavygee
heavygee deleted the feat/session-search-collapsed-query branch August 6, 2026 11:02
heavygee added a commit to heavygee/hapi that referenced this pull request Aug 6, 2026
Merged upstream as tiann#1391. Wave rematerialize owned by Meta.

Co-authored-by: Cursor <cursoragent@cursor.com>
heavygee added a commit to heavygee/hapi that referenced this pull request Aug 6, 2026
Absorb tiann#1376 session-summary hub toggle (opt-in) + tiann#1388/tiann#1390/tiann#1391.
Keep soup Overseer/FUE/PR-awareness/runners on Settings → General.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:web Web PWA / React client low-impact Focused / low-blast-radius change; estate lane B promote candidate (PR merge policy)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session search: show truncated query when collapsed (not just indicator dot)

2 participants