Skip to content

fix(web): prevent wasm optimization from breaking startup - #111

Merged
timcogan merged 1 commit into
masterfrom
fix/web-wasm-startup
Aug 3, 2026
Merged

fix(web): prevent wasm optimization from breaking startup#111
timcogan merged 1 commit into
masterfrom
fix/web-wasm-startup

Conversation

@timcogan

@timcogan timcogan commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Build & Deployment

    • Web builds now publish the generated WebAssembly output directly, providing consistent results between local and Pages builds.
    • Removed the additional WebAssembly optimization step from automated deployments.
  • Documentation

    • Updated local build guidance to reflect the streamlined WebAssembly build process.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 70ebb615-c13a-4d65-a582-471a2ae87a76

📥 Commits

Reviewing files that changed from the base of the PR and between bdae209 and f125060.

📒 Files selected for processing (3)
  • .github/workflows/pages.yml
  • RELEASE.md
  • scripts/build-web-demo.sh
💤 Files with no reviewable changes (1)
  • .github/workflows/pages.yml

📝 Walkthrough

Walkthrough

The web build now publishes unoptimized wasm-bindgen output directly. The Pages workflow no longer installs Binaryen, and RELEASE.md documents the matching local and Pages build behavior.

Changes

WASM build output

Layer / File(s) Summary
Publish direct wasm-bindgen output
scripts/build-web-demo.sh
The script hashes and installs the original wasm-bindgen WASM file without wasm-opt fallback handling.
Align Pages workflow and documentation
.github/workflows/pages.yml, RELEASE.md
The Pages workflow no longer installs Binaryen. The release documentation describes equivalent local and Pages modules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required summary, testing, screenshots, and checklist information is missing. Add the required sections, describe the WASM change, record testing results, and complete the checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the web WASM optimization fix and its startup impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web-wasm-startup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timcogan
timcogan merged commit c06d62e into master Aug 3, 2026
11 checks passed
@timcogan
timcogan deleted the fix/web-wasm-startup branch August 3, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant