Skip to content

fix(ci): ensure matching wasm-bindgen CLI is installed - #112

Merged
timcogan merged 1 commit into
masterfrom
fix/pages-wasm-bindgen-setup
Aug 3, 2026
Merged

fix(ci): ensure matching wasm-bindgen CLI is installed#112
timcogan merged 1 commit into
masterfrom
fix/pages-wasm-bindgen-setup

Conversation

@timcogan

@timcogan timcogan commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Improved the web build workflow by ensuring the required tooling is installed reliably.
    • Added a version check to confirm the installed build tool is available.
    • Updated build validation to avoid requiring an unnecessary system command.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 512c089c-3c54-48dc-ace3-e439335b2c32

📥 Commits

Reviewing files that changed from the base of the PR and between c06d62e and eb979e0.

📒 Files selected for processing (2)
  • .github/workflows/pages.yml
  • scripts/build-web-demo.sh

📝 Walkthrough

Walkthrough

The Pages workflow now force-installs and verifies the wasm-bindgen CLI. The web demo build script no longer requires cp during command validation.

Changes

Web build environment

Layer / File(s) Summary
wasm-bindgen installation verification
.github/workflows/pages.yml
The workflow force-installs the wasm-bindgen CLI and checks its installed version.
Build command validation
scripts/build-web-demo.sh
The script removes cp from its required-command list.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • timcogan/perspecta#111: Modifies the same Pages workflow and web build script for wasm-bindgen installation and WASM artifact handling.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description and does not provide the required summary, testing details, screenshots guidance, or checklist. Add a description with the required Summary, Testing, Screenshots, and Checklist sections, including completed tests and any additional manual testing.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the CI change to install the matching wasm-bindgen CLI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pages-wasm-bindgen-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timcogan
timcogan merged commit 8bff094 into master Aug 3, 2026
11 checks passed
@timcogan
timcogan deleted the fix/pages-wasm-bindgen-setup branch August 3, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant