API calls retrieving all results may be slow#195
Merged
Conversation
Contributor
Author
|
@timols PTAL |
johnou
force-pushed
the
optimize_retrieve_all
branch
from
March 7, 2017 20:20
0513919 to
343d9a0
Compare
johnou
force-pushed
the
optimize_retrieve_all
branch
from
March 9, 2017 18:26
343d9a0 to
7874651
Compare
Motivation: Speed up API calls. Modifications: Set maximum per page param when retrieving all results. Result: Less calls to GitLab API endpoint when retrieving all results.
johnou
force-pushed
the
optimize_retrieve_all
branch
from
March 9, 2017 18:29
7874651 to
a271d4c
Compare
Contributor
Author
|
@timols thanks! When do you plan on dropping 1.2.8? |
Contributor
Author
|
@timols poke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Speed up API calls.
Modifications:
Set maximum per page param when retrieving all results.
Result:
Less calls to GitLab API endpoint when retrieving all results.
Fixes #162.