New Crowdin updates#192
Conversation
WalkthroughAll English strings in the Spanish, German, and Chinese locale files were replaced with their corresponding Spanish, German, and Chinese translations, respectively. Additionally, a new localization key Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
frontend/src/lib/i18n/locales/es-ES.json (2)
37-38: Inconsistent terminology: "app" vs "aplicación".Most entries use "aplicación"; avoid the Anglicism "app" for consistency.
Consider:
- "totpSuccessSubtitle": "Redirigiendo a tu app", + "totpSuccessSubtitle": "Redirigiendo a tu aplicación",
22-22: Add opening inverted question mark.Spanish interrogatives require an opening "¿".
For clarity and correctness:
- "continueInsecureRedirectSubtitle": "Estás intentando redirigir de <code>https</code> a <code>http</code> que no es seguro. ¿Estás seguro de que quieres continuar?", + "continueInsecureRedirectSubtitle": "¿Estás intentando redirigir de <code>https</code> a <code>http</code>, lo cual no es seguro? ¿Estás seguro de que quieres continuar?",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/lib/i18n/locales/es-ES.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (go)
|
About the second nitpick from coderabbitai: |
|
Don't worry, code rabbit won't touch the translations, it's just recommending with its poor multilingual knowledge lol. Whatever you translate in crowdin gets merged to main intact. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/src/lib/i18n/locales/pl-PL.json (1)
45-45: English string left in Polish locale – translate for consistency
unauthorizedIpSubtitleis still in English while every other entry in this file is Polish. This disrupts the user experience and defeats the purpose of the locale file.Suggested fix:
-"unauthorizedIpSubtitle": "Your IP address <code>{{ip}}</code> is not authorized to access the resource <code>{{resource}}</code>.", +"unauthorizedIpSubtitle": "Twój adres IP <code>{{ip}}</code> nie jest upoważniony do dostępu do zasobu <code>{{resource}}</code>.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
frontend/src/lib/i18n/locales/af-ZA.json(1 hunks)frontend/src/lib/i18n/locales/ar-SA.json(1 hunks)frontend/src/lib/i18n/locales/ca-ES.json(1 hunks)frontend/src/lib/i18n/locales/cs-CZ.json(1 hunks)frontend/src/lib/i18n/locales/da-DK.json(1 hunks)frontend/src/lib/i18n/locales/de-DE.json(3 hunks)frontend/src/lib/i18n/locales/el-GR.json(1 hunks)frontend/src/lib/i18n/locales/en-US.json(1 hunks)frontend/src/lib/i18n/locales/es-ES.json(1 hunks)frontend/src/lib/i18n/locales/fi-FI.json(1 hunks)frontend/src/lib/i18n/locales/fr-FR.json(1 hunks)frontend/src/lib/i18n/locales/he-IL.json(1 hunks)frontend/src/lib/i18n/locales/hu-HU.json(1 hunks)frontend/src/lib/i18n/locales/it-IT.json(1 hunks)frontend/src/lib/i18n/locales/ja-JP.json(1 hunks)frontend/src/lib/i18n/locales/ko-KR.json(1 hunks)frontend/src/lib/i18n/locales/nl-NL.json(1 hunks)frontend/src/lib/i18n/locales/no-NO.json(1 hunks)frontend/src/lib/i18n/locales/pl-PL.json(1 hunks)frontend/src/lib/i18n/locales/pt-BR.json(1 hunks)frontend/src/lib/i18n/locales/pt-PT.json(1 hunks)frontend/src/lib/i18n/locales/ro-RO.json(1 hunks)frontend/src/lib/i18n/locales/ru-RU.json(1 hunks)frontend/src/lib/i18n/locales/sr-SP.json(1 hunks)frontend/src/lib/i18n/locales/sv-SE.json(1 hunks)frontend/src/lib/i18n/locales/tr-TR.json(1 hunks)frontend/src/lib/i18n/locales/uk-UA.json(1 hunks)frontend/src/lib/i18n/locales/vi-VN.json(1 hunks)frontend/src/lib/i18n/locales/zh-CN.json(3 hunks)frontend/src/lib/i18n/locales/zh-TW.json(1 hunks)
✅ Files skipped from review due to trivial changes (25)
- frontend/src/lib/i18n/locales/nl-NL.json
- frontend/src/lib/i18n/locales/ca-ES.json
- frontend/src/lib/i18n/locales/uk-UA.json
- frontend/src/lib/i18n/locales/fr-FR.json
- frontend/src/lib/i18n/locales/af-ZA.json
- frontend/src/lib/i18n/locales/ro-RO.json
- frontend/src/lib/i18n/locales/ar-SA.json
- frontend/src/lib/i18n/locales/pt-PT.json
- frontend/src/lib/i18n/locales/sv-SE.json
- frontend/src/lib/i18n/locales/he-IL.json
- frontend/src/lib/i18n/locales/ko-KR.json
- frontend/src/lib/i18n/locales/it-IT.json
- frontend/src/lib/i18n/locales/zh-TW.json
- frontend/src/lib/i18n/locales/en-US.json
- frontend/src/lib/i18n/locales/cs-CZ.json
- frontend/src/lib/i18n/locales/fi-FI.json
- frontend/src/lib/i18n/locales/pt-BR.json
- frontend/src/lib/i18n/locales/tr-TR.json
- frontend/src/lib/i18n/locales/da-DK.json
- frontend/src/lib/i18n/locales/hu-HU.json
- frontend/src/lib/i18n/locales/sr-SP.json
- frontend/src/lib/i18n/locales/el-GR.json
- frontend/src/lib/i18n/locales/vi-VN.json
- frontend/src/lib/i18n/locales/ja-JP.json
- frontend/src/lib/i18n/locales/no-NO.json
🚧 Files skipped from review as they are similar to previous changes (3)
- frontend/src/lib/i18n/locales/zh-CN.json
- frontend/src/lib/i18n/locales/es-ES.json
- frontend/src/lib/i18n/locales/de-DE.json
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Summary by CodeRabbit