New Crowdin updates#660
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request updates Simplified and Traditional Chinese locale files, translating numerous authorization/OAuth and scope-related UI strings; it also adds Changes
Sequence Diagram(s)(omitted — changes are translation/value updates only) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 15.61% 15.61%
=======================================
Files 49 49
Lines 3592 3592
=======================================
Hits 561 561
Misses 2974 2974
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/src/lib/i18n/locales/zh-CN.json`:
- Line 65: The string key "authorizeSubtitle" uses the informal pronoun "你"
while nearby keys like "authorizeSubtitleOAuth" use the polite "您"; update the
value of authorizeSubtitle to replace "你" with "您" so the tone matches other
user-facing strings (e.g., compare authorizeSubtitleOAuth) and maintain
consistent formal address across the zh-CN locale.
- Line 72: The key authorizeErrorMissingParams is still in English; update its
value to a Chinese translation for user-facing display by replacing "The
following parameters are missing: {{missingParams}}" with a Chinese string such
as "缺少以下参数:{{missingParams}}", ensuring the placeholder {{missingParams}} is
preserved exactly.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/src/lib/i18n/locales/zh-TW.json`:
- Line 54: The translation value for the "errorSubtitleInfo" key has a spurious
leading full-width double colon and uses a half-width comma; update the string
by removing the leading "::" prefix and replacing the half-width comma after "時"
with a full-width Chinese comma "," so it matches the zh-CN version and the rest
of the file's punctuation style.
- Line 72: The translation string for "authorizeErrorMissingParams" uses a
half-width colon before the placeholder; update the value for the
"authorizeErrorMissingParams" key to use a full-width Chinese colon (:) so it
matches other entries (i.e., change "下列參數遺失:{{missingParams}}" to use the
full-width colon before {{missingParams}}).
- Around line 67-68: Update the zh-TW strings for the authorize loading texts:
replace the unconventional "……正在載入……" (authorizeLoadingTitle) with a standard
trailing-ellipsis form such as "正在載入..." and populate authorizeLoadingSubtitle
with the appropriate Traditional Chinese translation copied/adapted from the
zh-CN subtitle (or, if intentionally blank, add a comment explaining why it's
empty); target the keys authorizeLoadingTitle and authorizeLoadingSubtitle when
making the change.
- Around line 64-66: The three authorization message keys authorizeCardTitle,
authorizeSubtitle, and authorizeSubtitleOAuth are still in English; replace
their values with proper Traditional Chinese translations (use the zh-CN
equivalents as a reference and adapt wording to zh-TW conventions) so the
user-facing strings in the authorize flow are fully localized; update the JSON
entries for "authorizeCardTitle", "authorizeSubtitle", and
"authorizeSubtitleOAuth" accordingly.
---
Duplicate comments:
In `@frontend/src/lib/i18n/locales/zh-CN.json`:
- Line 65: The string for the "authorizeSubtitle" key uses the informal pronoun
"你" while the rest of user-facing strings (e.g., "authorizeSubtitleOAuth") use
the polite "您"; update the value of "authorizeSubtitle" to replace "你" with "您"
so the tone is consistent across the locale file, ensuring the rest of the
sentence remains unchanged.
Summary by CodeRabbit