New Crowdin updates#269
Conversation
|
""" WalkthroughThe Serbian (sr-SP) localization JSON file was updated to provide Serbian Cyrillic translations for several login-related UI strings, replacing their previous English values. Additionally, two new keys, "fieldRequired" and "invalidInput," were added across all locale JSON files with appropriate translations or English placeholders. No changes were made to code or exported entities; only string values in localization files were modified or appended. Changes
Sequence Diagram(s)(No sequence diagrams generated as changes are limited to localization JSON files without control flow or feature logic modifications.) Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/lib/i18n/locales/sr-SP.json (1)
10-16: Consider translating the remaining login-flow strings for consistencyKeys such as
loginFailRateLimit,loginSuccessTitle,loginSuccessSubtitle, and the OAuth-related messages are still in English. Updating them would provide users with a fully-localized experience.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/lib/i18n/locales/sr-SP.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: ci
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
🔇 Additional comments (1)
frontend/src/lib/i18n/locales/sr-SP.json (1)
2-9: Translations & syntax look goodThe new Cyrillic strings are well-formed, free of placeholder/HTML issues, and keep the JSON valid.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 12.66% 20.14% +7.48%
==========================================
Files 24 24
Lines 2164 2214 +50
==========================================
+ Hits 274 446 +172
+ Misses 1875 1733 -142
- Partials 15 35 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
frontend/src/lib/i18n/locales/de-DE.json (1)
54-56: Consider translating the newly-added strings to German before shipping
"forgotPasswordMessage","fieldRequired"and"invalidInput"are still in English, which breaks the locale’s UX consistency.
If the PR goal is just to introduce the keys and placeholders, keep as-is; otherwise, add German equivalents, e.g.:-"forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.", -"fieldRequired": "This field is required", -"invalidInput": "Invalid input" +"forgotPasswordMessage": "Du kannst dein Passwort zurücksetzen, indem du die Umgebungsvariable `USERS` änderst.", +"fieldRequired": "Dieses Feld ist erforderlich", +"invalidInput": "Ungültige Eingabe"Confirm whether placeholders are intentional or need proper German translations before merge.
frontend/src/lib/i18n/locales/pl-PL.json (1)
54-54: Inconsistent code-style markup inside translation string
Previous messages embed inline code using<code>{{…}}</code>tags (see lines 22, 41 etc.). The new"forgotPasswordMessage"uses Markdown-style back-ticks instead. Consider switching to the same<code>HTML tags to keep rendering consistent across all messages.frontend/src/lib/i18n/locales/el-GR.json (1)
55-56: Translate the newly-added validation strings to Greek for locale consistencyBoth
fieldRequiredandinvalidInputare left in English. All other strings in this file are Greek, so these will suddenly appear in English in an otherwise Greek UI.- "fieldRequired": "This field is required", - "invalidInput": "Invalid input" + "fieldRequired": "Το πεδίο αυτό είναι υποχρεωτικό", + "invalidInput": "Μη έγκυρη εισαγωγή"Unless there is a deliberate reason to keep these keys untranslated (e.g. awaiting professional localisation), please update them or add a TODO comment so the mismatch does not ship unnoticed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
frontend/src/lib/i18n/locales/af-ZA.json(1 hunks)frontend/src/lib/i18n/locales/ar-SA.json(1 hunks)frontend/src/lib/i18n/locales/ca-ES.json(1 hunks)frontend/src/lib/i18n/locales/cs-CZ.json(1 hunks)frontend/src/lib/i18n/locales/da-DK.json(1 hunks)frontend/src/lib/i18n/locales/de-DE.json(1 hunks)frontend/src/lib/i18n/locales/el-GR.json(1 hunks)frontend/src/lib/i18n/locales/en-US.json(1 hunks)frontend/src/lib/i18n/locales/es-ES.json(1 hunks)frontend/src/lib/i18n/locales/fi-FI.json(1 hunks)frontend/src/lib/i18n/locales/fr-FR.json(1 hunks)frontend/src/lib/i18n/locales/he-IL.json(1 hunks)frontend/src/lib/i18n/locales/hu-HU.json(1 hunks)frontend/src/lib/i18n/locales/it-IT.json(1 hunks)frontend/src/lib/i18n/locales/ja-JP.json(1 hunks)frontend/src/lib/i18n/locales/ko-KR.json(1 hunks)frontend/src/lib/i18n/locales/nl-NL.json(1 hunks)frontend/src/lib/i18n/locales/no-NO.json(1 hunks)frontend/src/lib/i18n/locales/pl-PL.json(1 hunks)frontend/src/lib/i18n/locales/pt-BR.json(1 hunks)frontend/src/lib/i18n/locales/pt-PT.json(1 hunks)frontend/src/lib/i18n/locales/ro-RO.json(1 hunks)frontend/src/lib/i18n/locales/ru-RU.json(1 hunks)frontend/src/lib/i18n/locales/sr-SP.json(1 hunks)frontend/src/lib/i18n/locales/sv-SE.json(1 hunks)frontend/src/lib/i18n/locales/tr-TR.json(1 hunks)frontend/src/lib/i18n/locales/uk-UA.json(1 hunks)frontend/src/lib/i18n/locales/vi-VN.json(1 hunks)frontend/src/lib/i18n/locales/zh-CN.json(1 hunks)frontend/src/lib/i18n/locales/zh-TW.json(1 hunks)
✅ Files skipped from review due to trivial changes (23)
- frontend/src/lib/i18n/locales/ro-RO.json
- frontend/src/lib/i18n/locales/tr-TR.json
- frontend/src/lib/i18n/locales/pt-BR.json
- frontend/src/lib/i18n/locales/sv-SE.json
- frontend/src/lib/i18n/locales/vi-VN.json
- frontend/src/lib/i18n/locales/fi-FI.json
- frontend/src/lib/i18n/locales/en-US.json
- frontend/src/lib/i18n/locales/es-ES.json
- frontend/src/lib/i18n/locales/zh-CN.json
- frontend/src/lib/i18n/locales/uk-UA.json
- frontend/src/lib/i18n/locales/ja-JP.json
- frontend/src/lib/i18n/locales/ca-ES.json
- frontend/src/lib/i18n/locales/cs-CZ.json
- frontend/src/lib/i18n/locales/nl-NL.json
- frontend/src/lib/i18n/locales/af-ZA.json
- frontend/src/lib/i18n/locales/pt-PT.json
- frontend/src/lib/i18n/locales/ko-KR.json
- frontend/src/lib/i18n/locales/da-DK.json
- frontend/src/lib/i18n/locales/zh-TW.json
- frontend/src/lib/i18n/locales/ar-SA.json
- frontend/src/lib/i18n/locales/it-IT.json
- frontend/src/lib/i18n/locales/no-NO.json
- frontend/src/lib/i18n/locales/hu-HU.json
🚧 Files skipped from review as they are similar to previous changes (1)
- frontend/src/lib/i18n/locales/sr-SP.json
🔇 Additional comments (2)
frontend/src/lib/i18n/locales/fr-FR.json (1)
55-56: Provide French translations for the new validation messages
"fieldRequired"and"invalidInput"are still in English while this is the French locale. End-users will suddenly see English fallback text amid otherwise French UI.
Suggested translations:- "fieldRequired": "This field is required", - "invalidInput": "Invalid input" + "fieldRequired": "Ce champ est obligatoire", + "invalidInput": "Entrée invalide"Please confirm with the translator or Crowdin before merging.
frontend/src/lib/i18n/locales/pl-PL.json (1)
55-56: Provide actual Polish translations for the newly-added validation messages
Both"fieldRequired"and"invalidInput"are still in English. This breaks localisation consistency for end-users who have selected Polish. Please supply Polish equivalents (e.g."To pole jest wymagane"/"Nieprawidłowe dane"or similar) or, if placeholders are intentional, add a TODO comment so translators know these strings are pending.
| "fieldRequired": "This field is required", | ||
| "invalidInput": "Invalid input" |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
New validation strings left untranslated
"fieldRequired" and "invalidInput" are English. Suggested Hebrew equivalents:
-"fieldRequired": "This field is required",
-"invalidInput": "Invalid input"
+"fieldRequired": "שדה זה הינו חובה",
+"invalidInput": "קלט לא תקין"Confirm wording with a native speaker or the Crowdin translation before merging.
Add missing Hebrew translations for validation messages
It looks like the Hebrew locale still contains English strings for two validation keys. Please update them in frontend/src/lib/i18n/locales/he-IL.json at lines 55–56:
- "fieldRequired": "This field is required",
- "invalidInput": "Invalid input"
+ "fieldRequired": "שדה זה הינו חובה",
+ "invalidInput": "קלט לא תקין"Confirm the exact wording with a native speaker or via Crowdin before merging.
🤖 Prompt for AI Agents
In frontend/src/lib/i18n/locales/he-IL.json at lines 55 to 56, the values for
"fieldRequired" and "invalidInput" are still in English. Replace these English
strings with their correct Hebrew translations. Verify the translations with a
native speaker or use Crowdin to ensure accuracy before finalizing the update.
| "errorTitle": "An error occurred", | ||
| "errorSubtitle": "An error occurred while trying to perform this action. Please check the console for more information.", | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable." | ||
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Key added with English text in Hebrew locale
"forgotPasswordMessage" is still in English. Provide a Hebrew translation to keep the file fully localized, e.g.:
-"forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.",
+"forgotPasswordMessage": "באפשרותך לאפס את הסיסמה על-ידי שינוי משתנה הסביבה `USERS`.",🏁 Script executed:
#!/bin/bash
grep -n '"forgotPasswordMessage"' frontend/src/lib/i18n/locales/he-IL.jsonLength of output: 185
Translate forgotPasswordMessage to Hebrew
The value on line 54 is still in English and needs a Hebrew translation for the he-IL locale.
File: frontend/src/lib/i18n/locales/he-IL.json
Line: 54
Suggested change:
-"forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.",
+"forgotPasswordMessage": "באפשרותך לאפס את הסיסמה על-ידי שינוי משתנה הסביבה `USERS`.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.", | |
| "forgotPasswordMessage": "באפשרותך לאפס את הסיסמה על-ידי שינוי משתנה הסביבה `USERS`.", |
🤖 Prompt for AI Agents
In frontend/src/lib/i18n/locales/he-IL.json at line 54, the value for
"forgotPasswordMessage" is still in English. Replace the English text with the
correct Hebrew translation for this message to match the he-IL locale.
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.", | ||
| "fieldRequired": "This field is required", | ||
| "invalidInput": "Invalid input" |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Untranslated English strings in Russian locale
The newly-added keys keep English placeholders, so users with ru-RU selected will suddenly see mixed-language UI. Please provide proper Russian translations (or fall back to the generic en-US file).
Suggested patch:
-"forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.",
-"fieldRequired": "This field is required",
-"invalidInput": "Invalid input"
+"forgotPasswordMessage": "Вы можете сбросить пароль, изменив переменную окружения `USERS`.",
+"fieldRequired": "Это поле обязательно для заполнения",
+"invalidInput": "Неверный ввод"Provide Russian translations for new keys in ru-RU.json
The ru-RU.json locale file still contains English strings for the newly-added keys, which will result in mixed-language UI for Russian users. Please replace them with proper Russian translations:
• File: frontend/src/lib/i18n/locales/ru-RU.json
Lines: 54–56
Suggested patch:
-"forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.",
-"fieldRequired": "This field is required",
-"invalidInput": "Invalid input"
+"forgotPasswordMessage": "Вы можете сбросить пароль, изменив переменную окружения `USERS`.",
+"fieldRequired": "Это поле обязательно для заполнения",
+"invalidInput": "Неверный ввод"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "forgotPasswordMessage": "You can reset your password by changing the `USERS` environment variable.", | |
| "fieldRequired": "This field is required", | |
| "invalidInput": "Invalid input" | |
| "forgotPasswordMessage": "Вы можете сбросить пароль, изменив переменную окружения `USERS`.", | |
| "fieldRequired": "Это поле обязательно для заполнения", | |
| "invalidInput": "Неверный ввод" |
🤖 Prompt for AI Agents
In frontend/src/lib/i18n/locales/ru-RU.json at lines 54 to 56, the new keys
still have English strings which will cause mixed-language UI for Russian users.
Replace the English text for "forgotPasswordMessage", "fieldRequired", and
"invalidInput" with their correct Russian translations to ensure consistent
localization.
1 participant
Summary by CodeRabbit