Skip to content

ide-integration: update to use proper GOROOT - #112

Merged
deadprogram merged 1 commit into
devfrom
ide-integration-update
Sep 17, 2020
Merged

ide-integration: update to use proper GOROOT#112
deadprogram merged 1 commit into
devfrom
ide-integration-update

Conversation

@aykevl

@aykevl aykevl commented Sep 7, 2020

Copy link
Copy Markdown
Member

This depends on tinygo-org/tinygo#1362.

@sago35

sago35 commented Sep 7, 2020

Copy link
Copy Markdown
Member

I tried this with vim.
This is a good and simple way for non-developers to check the source code.
I like that it's very easy to do.

However, a developer editing a machine package, for example, would need to know how to do the original.

@aykevl

aykevl commented Sep 7, 2020

Copy link
Copy Markdown
Member Author

The cached GOROOT will contain symbolic links, so any edit to the machine package is also an edit to the cached GOROOT. So, this also works for developers of TinyGo.

You only need to change the settings with uncommon updates, such as when you move the TinyGo location or when you update the Go version.

@sago35

sago35 commented Sep 7, 2020

Copy link
Copy Markdown
Member

Cool!

@deadprogram

Copy link
Copy Markdown
Member

Is this ready to move out of draft yet?

@sago35

sago35 commented Sep 16, 2020

Copy link
Copy Markdown
Member

This approach only works with recent dev branches.
I think it won't be possible to merge into a release branch until tinygo 0.15 is released.

@sago35

sago35 commented Sep 17, 2020

Copy link
Copy Markdown
Member

@deadprogram @aykevl
tinygo 0.15 has been released, so I guess it's now mergeable.

@deadprogram
deadprogram marked this pull request as ready for review September 17, 2020 12:05
@deadprogram

Copy link
Copy Markdown
Member

OK, merging. Thanks!

@deadprogram
deadprogram merged commit c659748 into dev Sep 17, 2020
@deadprogram
deadprogram deleted the ide-integration-update branch September 17, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants