Production release: Logged out project creation flow #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redirects user to login page instead of registration page for now.
…om Coder Bot. It can now be used for rendering non error messages as well. Renamed the component as well to CoderBot.
… to Continue button for creating project.
removed modal left overs and clean up related code
…ut modal — Clean up Github issue#898, Consolidate the two steps, for project and product type selection, to one step — Created new components to render the consolidated view of project type selection
* dev: Removed feature branch from deployable branches. Github issue#880, Features changes are not reflected in side panel without saving the changes -- Fixed issue with change alert being shown even after saving the changes. Github issue#682, Permalink for status post and discussions message -- Added back the route params to be passed to FeedContainer component. Not sure, but without this argument, auto scrolling fails to work properly. trying deploying feature branch Github issue#682, Permalink for status post and discussions message -- Removed unused params Github issue#682, Permalink for status post and discussions message -- Removed route for permalink on dashboard. Instead used hash based implementation. Fixed lint errors Github issue#880, Features changes are not reflected in side panel without saving the changes -- Initial commit to update features value in formsy form model Github issue#682, Permalink for status post and discussions message -- Implemented scroll to discussion feature on discussions page when URL has specific dicussion specified in it -- Investigated dashboard page to implement the same scroll to feed feature -- Came up with two options: one is to use hash params to specify particular feed and another was to use REST url like we have for discussions page Github issue#873, Manager does not get manager access immediately after joining the project -- Updated projectNonDirty state as well on every action that can update project Github issue#802, can add more screen -- Utilized the on the fly update of other form sections on every form change event. Updated SpecQuestion component to use dirty project value for numberOfScreens question
— Added validation for project details form
…ect type and product selection step.
— Updated ProjectWizard and Wizard components to render modal controls (back and close buttons) with props — Updated TopbarContainer to render ProjectWizard as modal instead of redirecting user to /new-project route when user is logged in and clicking on the New Project button.
Updated travis config to deploy the deep links branch to dev env.
…ls JSON) in ES cluster — It seems ES does not allow indexing same field with two different types. Since we made number of screens and primary target questions non skippable in specification tab, it started to fail updating the project update in ES cluster because of that reason. When these were skippable questions, the value of corresponding fields was an object and since we made it compulsory field, it started to save a primitive value in it which is causing ES cluster to fail in indexing the updates. The same error is causing troubles with indexing the project on creation because now with new flow we are setting the values for these two fields (along with goal and users questions) as concrete/primitive value instead of an object. This was preventing the new challenges from listing on projects page.
…ls JSON) in ES cluster — Fixing the issue with updating ES cluster with updates when number of screens or primary target questions are updated. They are not being updated in ES cluster since we made them compulsory (non skippable) questions.
This reverts commit 72f0f9e.
…th details JSON) in ES cluster" This reverts commit b59dc57.
…th details JSON) in ES cluster" This reverts commit 9b932b7.
…ls JSON) in ES cluster — After reverting previous changes for fixing the same issue, fixed the dev data instead and now making the only required changes for new projects.
…yles a theme for the text input.
— Fixed product icons
— Added icon for Start over button
…project creation flow — Refactored layout to allow separate top bar components per route instead of handling that with if else in single component
…project creation flow — Removed unused files
…t creation flow — Updated uses of TiledRadioGroup component to be tabable
… into shizhouxing-issue-1016
… into shizhouxing-issue-1021
… into shizhouxing-issue-1022
… into shizhouxing-issue-1033
Feature/copy changes
— Implemented requested changes
Feature/message edit delete
# Conflicts: # package.json
mtwomey
approved these changes
Aug 8, 2017
Contributor
mtwomey
left a comment
mtwomey
left a comment
There was a problem hiding this comment.
After a discussion with Filipp we're going to push this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @fnisen @mtwomey @gondzo @ajefts @dmessing