Skip to content

[BASE-55] Setup test runner#2

Merged
bytasv merged 1 commit into
masterfrom
base-55-setup-test-runner
Dec 6, 2018
Merged

[BASE-55] Setup test runner#2
bytasv merged 1 commit into
masterfrom
base-55-setup-test-runner

Conversation

@bytasv
Copy link
Copy Markdown
Contributor

@bytasv bytasv commented Nov 30, 2018

[BASE-55] Setup test runner

Got jest up and running for Button component.
Added a couple of specs to see how react-testing-library looks like. So far it looks amazing and I feel it's an extremely good replacement for enzyme.

  • Add section to README about running tests locally

@bytasv bytasv added the Specs Changes regarding the spec suite label Nov 30, 2018
@bytasv bytasv self-assigned this Nov 30, 2018
@bytasv bytasv requested a review from MilosMosovsky November 30, 2018 15:51
@bytasv bytasv merged commit 5f47f0c into master Dec 6, 2018
@bytasv bytasv deleted the base-55-setup-test-runner branch December 6, 2018 11:23
oshchurtt added a commit that referenced this pull request Sep 19, 2019
* feat(Menu): draft of drill-down functionality

* chore: move MenuItem submenu-related logic into Menu

* feat(Menu): drilldown basic functionality

* chore(Menu): drilldown example to demo 3rd level submenu

* feat(Menu): add 'back' button for nested menus

* chore(Menu): improved Drilldown example

* fix(Menu): polish drilldown functionality

* chore(Menu): simplify some logic

* chore(MenuItem): try fixing some of the failed tests

* fix(Menu): fix some unit tests; add a test

* chore(Menu): added visual snapshot for nested

* refactor(Menu): drill based on context

* chore(MenuItem): a bit simplified the code

* fix(SidebarMenu): disallow nested menu navigation

* chore(Menu): fix visual snapshots and improve story layout

* fix(Menu): styling for 'back' button

* feat(Icon): add BackMinor16 and ChevronMinor16 icons

* chore(Menu): improve look of Drilldown example

* chore(Menu): improve look of Back button

* chore(MenuItem): improve chevron look

* chore(Menu): small cleanup

* chore(Menu): update visual snapshots

* chore(Menu): small fixes

* fix(Menu): fix circular dependncy consequence bug

* fix(Menu): fix circular dependncy consequence bug (#2)

* fix(Menu): simplify markup; improve look & feel

* fix(Menu): fix circular dependncy consequence bug (#3)

* chore(Menu): fix unit test snapshot

* chore(Menu): change order of examples in story book

* chore(Icon): removed 2 unneeded svg files

* chore(MenuItem): a small refactor

* chore(Menu): hide internal prop from docs

* chore(Menu): remove some unneeded code

* chore(Menu): extract menuContext into a separate file

* chore(Menu): some fixes

* chore(Menu): update drilldown snapshot with new chevron
conf pushed a commit that referenced this pull request Sep 19, 2019
# [3.11.0](v3.10.1...v3.11.0) (2019-09-19)

### Features

* **Menu:** [FX-436] drill-down functionality ([#684](#684)) ([3219579](3219579)), closes [#2](#2) [#3](#3)
@vshyrokov vshyrokov mentioned this pull request Oct 19, 2021
7 tasks
ruslan-sed added a commit that referenced this pull request Jun 11, 2024
ruslan-sed added a commit that referenced this pull request Jun 12, 2024
vedrani added a commit that referenced this pull request May 6, 2026
vedrani added a commit that referenced this pull request May 6, 2026
vedrani added a commit that referenced this pull request May 7, 2026
vedrani added a commit that referenced this pull request May 12, 2026
vedrani added a commit that referenced this pull request May 12, 2026
vedrani added a commit that referenced this pull request May 12, 2026
vedrani added a commit that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specs Changes regarding the spec suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants