[BASE-63] Create dist version of library#3
Closed
MilosMosovsky wants to merge 1 commit into
Closed
Conversation
toptal-bot
force-pushed
the
base-63-build-distribution
branch
5 times, most recently
from
3ee8469 to
3b8b81e
Compare
MilosMosovsky
commented
Dec 6, 2018
|
|
||
| const COMPONENTS = ['Button'] | ||
|
|
||
| const EXTERNALS = ['@material-ui/core/Button', '@material-ui/core/styles'] |
Contributor
Author
There was a problem hiding this comment.
I think this does nothing, it just clear warning from rollup that this is an external dependency
MilosMosovsky
force-pushed
the
base-63-build-distribution
branch
3 times, most recently
from
31e85ad to
620023b
Compare
havenchyk
reviewed
Dec 11, 2018
| @@ -0,0 +1,3 @@ | |||
| > 1% | |||
| Last 2 versions | |||
Contributor
There was a problem hiding this comment.
MilosMosovsky
force-pushed
the
base-63-build-distribution
branch
2 times, most recently
from
11610ad to
a3a0289
Compare
MilosMosovsky
force-pushed
the
base-63-build-distribution
branch
from
a3a0289 to
cccc477
Compare
4 tasks
oshchurtt
added a commit
that referenced
this pull request
Sep 17, 2019
oshchurtt
added a commit
that referenced
this pull request
Sep 19, 2019
oshchurtt
added a commit
that referenced
this pull request
Sep 19, 2019
oshchurtt
added a commit
that referenced
this pull request
Sep 19, 2019
oshchurtt
added a commit
that referenced
this pull request
Sep 19, 2019
oshchurtt
added a commit
that referenced
this pull request
Sep 19, 2019
* feat(Menu): draft of drill-down functionality * chore: move MenuItem submenu-related logic into Menu * feat(Menu): drilldown basic functionality * chore(Menu): drilldown example to demo 3rd level submenu * feat(Menu): add 'back' button for nested menus * chore(Menu): improved Drilldown example * fix(Menu): polish drilldown functionality * chore(Menu): simplify some logic * chore(MenuItem): try fixing some of the failed tests * fix(Menu): fix some unit tests; add a test * chore(Menu): added visual snapshot for nested * refactor(Menu): drill based on context * chore(MenuItem): a bit simplified the code * fix(SidebarMenu): disallow nested menu navigation * chore(Menu): fix visual snapshots and improve story layout * fix(Menu): styling for 'back' button * feat(Icon): add BackMinor16 and ChevronMinor16 icons * chore(Menu): improve look of Drilldown example * chore(Menu): improve look of Back button * chore(MenuItem): improve chevron look * chore(Menu): small cleanup * chore(Menu): update visual snapshots * chore(Menu): small fixes * fix(Menu): fix circular dependncy consequence bug * fix(Menu): fix circular dependncy consequence bug (#2) * fix(Menu): simplify markup; improve look & feel * fix(Menu): fix circular dependncy consequence bug (#3) * chore(Menu): fix unit test snapshot * chore(Menu): change order of examples in story book * chore(Icon): removed 2 unneeded svg files * chore(MenuItem): a small refactor * chore(Menu): hide internal prop from docs * chore(Menu): remove some unneeded code * chore(Menu): extract menuContext into a separate file * chore(Menu): some fixes * chore(Menu): update drilldown snapshot with new chevron
conf
pushed a commit
that referenced
this pull request
Sep 19, 2019
7 tasks
ruslan-sed
added a commit
that referenced
this pull request
May 29, 2024
ruslan-sed
added a commit
that referenced
this pull request
Jun 11, 2024
ruslan-sed
added a commit
that referenced
this pull request
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create
distfolder for library