feat(Menu): [FX-436] drill-down functionality#684
Merged
Conversation
4 tasks
bytasv
reviewed
Sep 16, 2019
bytasv
reviewed
Sep 16, 2019
bytasv
approved these changes
Sep 17, 2019
Contributor
bytasv
left a comment
bytasv
left a comment
There was a problem hiding this comment.
Looks good, lets rebase and 
denieler
changed the title
denieler
reviewed
Sep 17, 2019
vedrani
reviewed
Sep 17, 2019
denieler
reviewed
Sep 17, 2019
Collaborator
|
I found this problem with Back button hover. |
vedrani
approved these changes
Sep 19, 2019
Contributor
|
@oshchurtt please, rebase :) seems temploy is broken because of that |
denieler
approved these changes
Sep 19, 2019
oshchurtt
force-pushed
the
FX-436-menu-drilldown
branch
2 times, most recently
from
3816b42 to
1f04f61
Compare
havenchyk
approved these changes
Sep 19, 2019
Contributor
havenchyk
left a comment
havenchyk
left a comment
There was a problem hiding this comment.
Great job, don't be afraid to merge this and fix problems if any with another PR
| return ( | ||
| const { backButtonIcon, ...restClasses } = classes | ||
| const { pop } = useContext<MenuContextProps>(MenuContext) | ||
| const hasParentMenu = !!pop |
Contributor
There was a problem hiding this comment.
we usually use Boolean(pop)
| </TestMenu> | ||
| ) | ||
|
|
||
| fireEvent.click(getByText('Item 1')) |
Contributor
There was a problem hiding this comment.
I would maybe check only that back button inside the container, but using snapshots is also fine
oshchurtt
force-pushed
the
FX-436-menu-drilldown
branch
from
1f04f61 to
df31242
Compare
Collaborator
|
This could be done if followup ticket, but I would maybe increase icon left spacing. |
oshchurtt
force-pushed
the
FX-436-menu-drilldown
branch
from
99a86c6 to
a6500ae
Compare
Contributor
|
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
conf
pushed a commit
that referenced
this pull request
Sep 19, 2019
Contributor
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
Congratz on finally getting this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FX-436
Description
We want to allow nested
Menuand drilling down it's sub-menus.How to test
Review
propsin component with documentationexamplesfor component