fix(cli): home screen labels the env by remembered client name (bugbot #266)

[saadqbal]

What

The bare-CLI home screen labels the secure environment differently depending on state:

• Online / Starting → shows the Helm release name (tracebloc), because realProbeEnv sets envProbe{name: release.ReleaseName}.
• Offline → shows the remembered client name (acme-01), because the offline paths surface no name and resolveHomeModel falls back to remembered.

Same environment, two labels. resolveHomeModel only used remembered when the probe name was empty.

Fix

Prefer the remembered client name whenever it exists; keep the probe's release name only as a last-resort fallback (a release present on a machine that never cached a client). One-line change in resolveHomeModel.

Why the tests didn't catch it

The baseDeps fake probe returned the friendly name acme-01 — never the release name — so no test made the probe name differ from remembered. Added TestResolveHomeModel_PrefersRememberedNameOverReleaseName, where the probe returns tracebloc while remembered is acme-01; it fails on the old if env.name == "" logic and passes on the fix.

Verification

• gofmt clean; go test ./internal/cli/ green (incl. the new regression test).

Resolves the Cursor Bugbot "Home shows Helm release as env name" finding on #266. Once merged to develop, the promote PR #266 picks it up automatically.

🤖 Generated with Claude Code

---

Note

Low Risk
Small display-label fix in CLI home resolution with a targeted regression test; no auth, cluster, or data-path behavior changes.

Overview
The bare CLI home screen showed different secure-environment labels depending on state: Online/Starting used the cluster probe’s Helm release name (e.g. tracebloc), while Offline used the remembered client name (e.g. acme-01) because offline paths left the probe name empty and only then fell back to remembered.

resolveHomeModel now always prefers the remembered client name when one exists, and keeps the probe’s release name only when nothing was cached—so the same provisioned machine shows one user-facing label in every state. Comments document why release vs client names diverge.

Adds TestResolveHomeModel_PrefersRememberedNameOverReleaseName, with the probe returning tracebloc and remembered acme-01, which the previous if env.name == "" logic would not catch.

^{Reviewed by Cursor Bugbot for commit 426659e. Bugbot is set up for automated code reviews on this repo. Configure here.}