Skip to content

test(push): coverage wave 2 (batch 1-2: category helpers + CSV-validator errors)#272

Merged
saadqbal merged 2 commits into
developfrom
test/coverage-wave2-push
Jul 14, 2026
Merged

test(push): coverage wave 2 (batch 1-2: category helpers + CSV-validator errors)#272
saadqbal merged 2 commits into
developfrom
test/coverage-wave2-push

Conversation

@LukasWodka

@LukasWodka LukasWodka commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Wave-2 coverage for internal/push (87.7% → 89.0%): pure category/family helpers (were 0%) + the CSV-validator file-error arms. First installment of the push grind — the package's remaining gap is spread across ~50 functions (preflight validators, pod/stage lifecycle, orphan/list), so push→95% is a multi-PR effort. make ci green.

🤖 Generated with Claude Code


Note

Low Risk
No production code changes—only new unit tests for existing helpers and validators.

Overview
Adds test-only coverage in internal/push as the first wave toward higher package coverage (~87.7% → ~89%).

Category helpers (category_pure_coverage_test.go): exercises FamilyNoun / FamilyFromNoun round-trips and unknown-input fallbacks to tabular, non-empty FamilyNouns(), SupportedCategoriesList() including known task ids, and TextSidecarDir() for text task categories.

Preflight CSV validators (preflight_csverrors_coverage_test.go): asserts missing-file paths error for HasBOM, ReadCSVHeader, CheckTabularBOM, CheckHasDataRows, and CheckCSVEncoding; empty files fail header read; sub-3-byte files return no BOM without error.

Reviewed by Cursor Bugbot for commit 3dd13b7. Bugbot is set up for automated code reviews on this repo. Configure here.

LukasWodka and others added 2 commits July 14, 2026 11:48
FamilyNoun/FamilyFromNoun/FamilyNouns/SupportedCategoriesList (were 0%) +
TextSidecarDir happy path. First of several push batches toward 95%
(87.7% -> 88.5%); the package's remaining gap is spread across ~55 functions
(preflight validators, pod/stage lifecycle, orphan/list), a multi-PR grind.

make ci green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
HasBOM/ReadCSVHeader/CheckTabularBOM/CheckHasDataRows/CheckCSVEncoding open-error
arms (missing file), ReadCSVHeader empty-file EOF, HasBOM short-file. push
88.5% -> 89.0%.

make ci green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@LukasWodka LukasWodka self-assigned this Jul 14, 2026
@LukasWodka

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3dd13b7. Configure here.

@LukasWodka

Copy link
Copy Markdown
Contributor Author

👋 Heads-up — Code review queue is at 34 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@saadqbal saadqbal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Verified FamilyNoun/FamilyFromNoun defaults + round-trip, TextSidecarDir reading PrimarySubdir from the contract (MLM→sequences), and HasBOM's short-file n<3→(false,nil) arm vs the missing-file open error. Good coverage of the CSV-validator error paths. Clean.

@saadqbal
saadqbal merged commit 131b5f0 into develop Jul 14, 2026
22 checks passed
@saadqbal
saadqbal deleted the test/coverage-wave2-push branch July 14, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants