Fixes after merge of #155.#156
Merged
Merged
Conversation
arokem
commented
Jan 20, 2026
arokem
commented
Member
- Back off installation of sdist with all dependencies.
- Tests should still be fine because onnxruntime now optional.
- Back off installation of sdist with all dependencies. - Tests should still be fine because onnxruntime now optional.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the TestPyPI workflow to install the source distribution without optional dependencies, following changes from PR #155 that made onnxruntime an optional dependency.
Changes:
- Modified the sdist installation step to exclude optional dependencies (removed the
[all]extra) - Updated the step name to reflect that optional dependencies are no longer installed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arokem
added a commit
to arokem/pyAFQ
that referenced
this pull request
Jan 21, 2026
arokem
added a commit
that referenced
this pull request
Jan 21, 2026
Fix after merging #156. Skips nightly tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.