perf: Dependency reduction & JS update #105
Conversation
|
@mvayngrib, sorry for the messy diff caused by the change to ES2015 syntax. Here is a more readable diff of |
|
@Rapsssito I appreciate the effort, but tbh, i don't see a big benefit to this change. Converting to modern JS is nice, I agree, but I prob won't have time in the short term to review such a big diff |
|
@mvayngrib, I really need this PR to be merged since I am working on a few other PRs that depend on it. Plus, having a dependency for a native JavaScript feature is just pointless and unprofessional. I have attached screenshots from the diffs showed in VS Code, much more readable (most of it is just indentation corrections): |
Rapsssito
changed the title
Rapsssito
changed the title
# [2.6.0](v2.5.0...v2.6.0) (2020-08-15) ### Bug Fixes * **Android:** createSocket is now a blocking method ([#108](#108)) ([6796a7f](6796a7f)) * RN 62.0 compatibility ([#112](#112)) ([7d202de](7d202de)) ### Features * Add Typescript types and the option to enable debugging ([#114](#114)) ([11e6e49](11e6e49)) ### Performance Improvements * Dependency reduction & JS update ([#105](#105)) ([aac2bfa](aac2bfa))
# [3.2.0](v3.1.0...v3.2.0) (2020-08-15) ### Bug Fixes * **Android:** createSocket is now a blocking method ([#108](#108)) ([6796a7f](6796a7f)) ### Features * Add Typescript types and the option to enable debugging ([#114](#114)) ([11e6e49](11e6e49)) ### Performance Improvements * Dependency reduction & JS update ([#105](#105)) ([aac2bfa](aac2bfa))
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Dependencies reduction
inheritsby changing theUdpSocketclass to the ES2015 syntax and extendingEventEmitter, instead of usinginheritsfor the inheritance.utils.Test
Tested on one of my projects. Everything works correctly.