fix(Android): createSocket is now a blocking method #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapsssito
changed the title
yonghongren
added a commit
to yonghongren/react-native-udp
that referenced
this pull request
Apr 20, 2020
Picked up from tradle#108: Before, if you called createSocket('udp4') and bind() close together on production while running on a fast JS engine like Hermes, you would get the following error: "no client found with id X". This was caused because createSocket('udp4') was running asynchronously and had not push the new socket to the SparseArray when the bind() method was called.
Contributor
|
@mvayngrib What do you think of this? |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2020
# [2.6.0](v2.5.0...v2.6.0) (2020-08-15) ### Bug Fixes * **Android:** createSocket is now a blocking method ([#108](#108)) ([6796a7f](6796a7f)) * RN 62.0 compatibility ([#112](#112)) ([7d202de](7d202de)) ### Features * Add Typescript types and the option to enable debugging ([#114](#114)) ([11e6e49](11e6e49)) ### Performance Improvements * Dependency reduction & JS update ([#105](#105)) ([aac2bfa](aac2bfa))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2020
# [3.2.0](v3.1.0...v3.2.0) (2020-08-15) ### Bug Fixes * **Android:** createSocket is now a blocking method ([#108](#108)) ([6796a7f](6796a7f)) ### Features * Add Typescript types and the option to enable debugging ([#114](#114)) ([11e6e49](11e6e49)) ### Performance Improvements * Dependency reduction & JS update ([#105](#105)) ([aac2bfa](aac2bfa))
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if you called
createSocket('udp4')andbind()close together on production while running on a fast JS engine like Hermes, you would get the following error:"no client found with id X".This was caused because
createSocket('udp4')was running asynchronously and had not push the new socket to theSparseArraywhen thebind()method was called.