fix(golibafl): unbreak nautilus cmplog i2s#148
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the NautilusCmpLogI2SMutator in the Rust LibAFL runner to avoid timeouts in the grammar CMPLOG/I2S smoke test by (a) considering scalar CMPLOG comparisons (U8/U16/U32/U64) in addition to byte comparisons and (b) filtering the comparison set down to those that are relevant to the current input before spending the fixed mutation budget.
Changes:
- Extend CMPLOG pair extraction to include scalar comparison variants (U8/U16/U32/U64) by converting them into byte sequences.
- Add an early comparison filter that retains only comparisons where at least one side appears as a substring in the current input, reducing wasted work under
MAX_CMP_TRIES. - Keep the “longer-first” prioritization using the already-trimmed/stored byte vectors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the LibAFL smoke failure where the grammar CMPLOG/I2S run times out (no crash found).
NautilusCmpLogI2SMutator now also consumes scalar CMPLOG values (U8/U16/U32/U64) and filters comparisons to ones that appear in the current input, so it does not spend its fixed budget on unrelated comparisons.
Local check: bash misc/gosentry/tests/smoke_use_libafl_grammar_cmplog_i2s.sh