[pull] master from golang:master - #165
Merged
Merged
Conversation
Fchdir on Windows restores the working directory by calling GetFinalPathNameByHandleW and passing the resulting path to SetCurrentDirectoryW. With VOLUME_NAME_DOS, GetFinalPathNameByHandleW can return an extended UNC path such as \\?\UNC\server\share\dir. The existing normalization removed only the \\?\ prefix, producing UNC\server\share\dir, which is a relative path rather than a UNC path. SetCurrentDirectoryW can then fail with "The system cannot find the path specified." Handle the extended UNC form separately by converting \\?\UNC\ to \\. Keep the existing normalization for non-UNC extended paths. Fixes #80130 Change-Id: Ia70e59202ec42d986e25a5673faae88290ca4a7c
When a vector is multiplied by a broadcasted constant power of 2, replace the VPMULL instruction with a VPSLL. This is a performance optimization. Change-Id: Ie19eb696991ee45f451c7a546ced5ecea2f829c4 Reviewed-on: https://go-review.googlesource.com/c/go/+/790500 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
Clarify documentation. Improve grammar. In one case (Canonicalize), remove an unclear paragraph. Change-Id: Id9477ad760f0a3c8729717606dc282c2f8020597 Reviewed-on: https://go-review.googlesource.com/c/go/+/809162 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Equivalent but hopefully clearer approach as suggested in CL 662315. Change-Id: I305fa0af2bbdaacd1d521c1381f9ddced5b203b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/662375 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Damien Neil <dneil@google.com>
Explicitly document that ReverseProxy does not sanitize forwarded Cookie headers. Change-Id: I04231fa2c779beca80f7d8f41683e0e16a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/787261 Reviewed-by: Nicholas Husin <nsh@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Nicholas Husin <husin@google.com>
Avoids reusing cached .cover.go files with //line directives referencing a different source location. Change-Id: I2edb3279f32608276db6d45e8d6a83c16a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/809980 Auto-Submit: Damien Neil <dneil@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Matloob <matloob@golang.org>
For #77341 Change-Id: Ia06a43dd851910355ea22734bdf11b9d6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/804523 Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The modern way to enable/disable HTTP protocols is via
the Server.Protocols field.
Fix an unintentional change in behavior when not using
Server.Protocols:
- User sets Server.TLSNextProto to a non-nil map
which does not contain an "h2" key.
- User calls http2.ConfigureServer to add HTTP/2
support to the Server.
Historically, ConfigureServer would set the "h2" key
in TLSNextProto. After the move of HTTP/2 into std,
it no longer changes TLSNextProto. This results in
the net/http Server interpreting the missing "h2"
key in the above scenario as the user intentionally
disabling HTTP/2.
Fix this by initializing the server's HTTP/2 support
when ConfigureServer is called, which sets TLSNextProto's
"h2" key to a dummy value.
Fixes #80482
Change-Id: I497881423bc76deed2a59e355b59672f6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/803740
Reviewed-by: Nicholas Husin <nsh@golang.org>
Reviewed-by: Nicholas Husin <husin@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Inspired by CL 805200 Here are the performance numbers compiling tsgo: master: 492.74s ± 0.61σ 805200: 491.95s ± 1.34σ thisCL: 491.26s ± 0.74σ 805200 is bugged (O(n²) worst case since it doesn't use memoization on the outer scan loop). It also could use a single function wide bitset rather than a blockwise sparse which should make it faster. At which point it should be within noise distance at this CL. But this CL keeps the output is toposorted behavior which known bits use to limit recursion depth. Change-Id: I7365d1f8b29723885f6d994fdb62698fcb0abec8 Reviewed-on: https://go-review.googlesource.com/c/go/+/805780 Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com> Reviewed-by: Mark Freeman <markfreeman@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
…ions This restore the BP as a scratch register for ABI0 NOFRAME functions. Fixes #80710 Fixes #80709 Change-Id: Ie9d49f9364bcb30329ef901e4d02c2e3f9c69998 Reviewed-on: https://go-review.googlesource.com/c/go/+/809960 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: David Chase <drchase@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )