feat(ingest-cli): derive vocabulary from notations/vocabulary.yaml - #453
Closed
transitrix wants to merge 4 commits into
Closed
feat(ingest-cli): derive vocabulary from notations/vocabulary.yaml#453transitrix wants to merge 4 commits into
transitrix wants to merge 4 commits into
Conversation
…PRIMITIVES §4 The §4 materialisation-mode table still listed EQUIPMENT and INFORMATION_ENTITY as view-defined, predating the 2026-06-08 ADR that promoted both to standalone catalogued elements (EQUIPMENT at 04_technology/equipment/, renamed BUSINESS_OBJECT at 02_business/business-objects/). The rest of the document — the layer table, §7.14/§7.15 field schemas, and the ELEM-004/EQUIP-001/BOBJ-001 validation codes — already reflected the ADR; only this table and two supporting §4.1/§4.2 bullets had not caught up. Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com>
Publish notations/vocabulary.yaml as the closed-vocabulary source of truth (element TYPE registry, relation type enum, closed value vocabularies, rule codes). placement.mjs and validate.mjs derive their sets from it instead of holding their own literal copies, which also closes the pre-existing gap where placement.mjs was missing several catalogued TYPEs and validate.mjs's relation-kind set was missing several kinds. scripts/check-notations.mjs gains a VOC1 check cross-verifying the artefact against ELEMENT_PRIMITIVES.md §4. Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com>
2 tasks
transitrix
added
the
needs:human-merge
2 tasks
…lary-element-types Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com> # Conflicts: # scripts/check-notations.mjs # scripts/check-notations.test.mjs
…lary-element-types # Conflicts: # notations/vocabulary.yaml # scripts/check-notations.mjs # scripts/check-notations.test.mjs
Owner
Author
|
Superseded — everything this PR added (vocabulary.mjs, placement.mjs/validate.mjs derivation, VOC1) already reached main via #457 and #459, which absorbed this branch's commits on their way through the stacked chain. The only diff left standing was the vocabulary.yaml version-pin bump, which duplicates #463 (open, CI green). Closing in favor of #463. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notations/vocabulary.yamlas the closed-vocabulary source of truth: element TYPE registry, relationtypeenum, closed value vocabularies, and rule codes/severities.packages/ingest-cli/src/vocabulary.mjsloads and validates the artefact (fails closed on missing/corrupt/version-mismatched input);placement.mjsandvalidate.mjsnow derive their sets from it instead of holding their own literal copies.scripts/check-notations.mjsgains a VOC1 check cross-verifying the artefact'selement_typesagainstELEMENT_PRIMITIVES.md§4.ingest-skill-test.yml).Test plan
node scripts/check-notations.mjs— cleannode --test scripts/check-notations.test.mjs— 24 passing, including new VOC1 parser testsnode --test packages/ingest-cli/src/vocabulary.test.mjs— 15 passing (clean pass, real divergence, corrupted artefact, and derived-view cases)node --test packages/ingest-cli/src/packages.test.mjs— unaffected, still green🤖 Generated with Claude Code