feat(notations): add VOC2 — relation_types vs 17-relations.md §3 drift check - #457
Merged
Merged
Conversation
…PRIMITIVES §4 The §4 materialisation-mode table still listed EQUIPMENT and INFORMATION_ENTITY as view-defined, predating the 2026-06-08 ADR that promoted both to standalone catalogued elements (EQUIPMENT at 04_technology/equipment/, renamed BUSINESS_OBJECT at 02_business/business-objects/). The rest of the document — the layer table, §7.14/§7.15 field schemas, and the ELEM-004/EQUIP-001/BOBJ-001 validation codes — already reflected the ADR; only this table and two supporting §4.1/§4.2 bullets had not caught up. Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com>
Publish notations/vocabulary.yaml as the closed-vocabulary source of truth (element TYPE registry, relation type enum, closed value vocabularies, rule codes). placement.mjs and validate.mjs derive their sets from it instead of holding their own literal copies, which also closes the pre-existing gap where placement.mjs was missing several catalogued TYPEs and validate.mjs's relation-kind set was missing several kinds. scripts/check-notations.mjs gains a VOC1 check cross-verifying the artefact against ELEMENT_PRIMITIVES.md §4. Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com>
…t check Extends scripts/check-notations.mjs with the same shape as VOC1: every live relation kind in vocabulary.yaml's relation_types must match its endpoint TYPE set and ACTOR subtype narrowing in elements/17-relations.md §3's table, and vice versa. Also fixes the one divergence the first run surfaces: the offers relation was missing the from_subtype: [business_unit] narrowing the spec table and prose already document. Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com>
transitrix
added
the
needs:human-merge
2 tasks
…lary-element-types Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com> # Conflicts: # scripts/check-notations.mjs # scripts/check-notations.test.mjs
…gy/49-vocabulary-relation-types Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com> # Conflicts: # scripts/check-notations.mjs # scripts/check-notations.test.mjs
…459) Extends scripts/check-notations.mjs with the same shape as VOC1/VOC2: every value_vocabularies entry in vocabulary.yaml with a non-null spec has each of its values appear somewhere in that spec as (part of) a code span; an entry that also names a rule has that rule's row cross-checked so the row's own enumerated values match `values` exactly. decomposeSpan() normalises the several code-span shapes specs actually use (pipe list, brace set, several single-value spans) to a flat value list. The first run passes clean — no existing divergence in this block. Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com> Co-authored-by: Valerii Korobeinikov <vkgeorgia@icloud.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-notations.mjswith VOC2, matching the VOC1 pattern: every live relation kind innotations/vocabulary.yaml'srelation_typesmust match its endpoint TYPE set and ACTOR subtype narrowing inelements/17-relations.md§3's table, and vice versa. Fails closed on a missing/unparseable artefact.offerswas missingfrom_subtype: [business_unit], which the spec table and prose already document.Depends on #453 (still open, CI green) — this PR is based on that branch, per the stacked-PR exception (same as #454/#456 on the sibling epic). Please merge #453 first, then this one.
Test plan
node scripts/check-notations.mjs— cleannode --test scripts/check-notations.test.mjs— all pass (30/30)