Faraday 2.x and 1.x cross support #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
force-pushed
the
faraday-2-support
branch
from
f2dd977 to
9ab8651
Compare
exoego
force-pushed
the
faraday-2-support
branch
from
d7a62c8 to
e30feda
Compare
4 tasks
exoego
changed the title
exoego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added Faraday 2.x support while keeping Faraday 1.x support.
Overview
Note
You can see that Faraday
2.7.4and1.10.3are used in each CI jobs.https://github.com/treasure-data/trino-client-ruby/actions/runs/4239442131/jobs/7367502926
https://github.com/treasure-data/trino-client-ruby/actions/runs/4239441863/jobs/7367502185
Checklist