Skip to content

CI: Do not trigger "push" event on pull requests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
exoego merged 1 commit into from
Feb 22, 2023
Merged

CI: Do not trigger "push" event on pull requests #95

exoego merged 1 commit into from
Feb 22, 2023

Conversation

@exoego
Copy link
Contributor

@exoego exoego commented Feb 22, 2023 •
edited
Loading

Purpose

To make CI faster.

Overview

On pull requests, GitHub Actions are executed both on push and pull_request event at this moment.
This is redundant because same CI job is executed twice.
See #94 as example

After this PR, push event is triggered only when main and master branch (when PR is merged).

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@exoego exoego added the chore non user-facing trivial stuff (CI, refactoring, etc) label Feb 22, 2023
@exoego exoego changed the title CI: "push" event on pull requests are redundant CI: Do not trigger "push" event on pull requests Feb 22, 2023
@exoego exoego marked this pull request as ready for review February 22, 2023 04:51
@exoego exoego requested a review from a team as a code owner February 22, 2023 04:51
@exoego exoego merged commit f935407 into master Feb 22, 2023
@exoego exoego deleted the ci-opt branch February 22, 2023 04:53
@exoego exoego removed the doc label Feb 22, 2023
@exoego exoego mentioned this pull request Feb 22, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuokada yuokada yuokada approved these changes

Assignees

No one assigned

Labels

chore non user-facing trivial stuff (CI, refactoring, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@exoego @yuokada