Skip to content

build(deps): Bump filelock from 3.2.0 to 3.3.0 - #6737

Merged
skshetry merged 2 commits into
masterfrom
dependabot/pip/filelock-3.3.0
Oct 8, 2021
Merged

build(deps): Bump filelock from 3.2.0 to 3.3.0#6737
skshetry merged 2 commits into
masterfrom
dependabot/pip/filelock-3.3.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 4, 2021

Copy link
Copy Markdown
Contributor

Bumps filelock from 3.2.0 to 3.3.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
dependabot Bot requested a review from a team as a code owner October 4, 2021 03:47
@dependabot
dependabot Bot requested a review from pared October 4, 2021 03:47
@pared

pared commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Seems like filelock maintainers introduced conditional classes implementation in tox-dev/filelock#100 depending on user system.

abstract-class-instantiated error from pylint regards the situation when one would like to use UnixFileLock on Windows Machine or WindowsFileLock on Unix. In our test_remotes we are using

from filelock import FileLock

Which resolves to :

if sys.platform == "win32":
    FileLock = WindowsFileLock
elif has_fcntl:
    FileLock = UnixFileLock
else:
    FileLock = SoftFileLock

So we should not be affected by this particular error.

@pared
pared force-pushed the dependabot/pip/filelock-3.3.0 branch from 605400e to cf143a1 Compare October 6, 2021 11:41
@pared
pared requested a review from efiop October 6, 2021 11:44
@skshetry

skshetry commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator

@dependabot recreate

Bumps [filelock](https://github.com/tox-dev/py-filelock) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/tox-dev/py-filelock/releases)
- [Commits](tox-dev/filelock@3.2.0...3.3.0)

---
updated-dependencies:
- dependency-name: filelock
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/filelock-3.3.0 branch from cf143a1 to b1973a7 Compare October 8, 2021 09:06
@skshetry
skshetry merged commit 5a4f4d3 into master Oct 8, 2021
@skshetry
skshetry deleted the dependabot/pip/filelock-3.3.0 branch October 8, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants