Skip to content

fix(database): restrict TypeScript root inputs to src - #4386

Closed
hardikkaurani wants to merge 1 commit into
triggerdotdev:mainfrom
hardikkaurani:fix/database-ts5055-windows
Closed

fix(database): restrict TypeScript root inputs to src#4386
hardikkaurani wants to merge 1 commit into
triggerdotdev:mainfrom
hardikkaurani:fix/database-ts5055-windows

Conversation

@hardikkaurani

Copy link
Copy Markdown

Summary

This PR adds an explicit include pattern to internal-packages/database/tsconfig.json to restrict TypeScript root input files to the src directory.

Problem

Running the following command on Windows:

pnpm run dev --filter @trigger.dev/database

starts TypeScript in watch mode with declaration output enabled. Since the package tsconfig.json does not explicitly define an include pattern, the compiler may treat generated declaration files inside dist/ as input files, resulting in the following error:

error TS5055: Cannot write file '.../dist/index.d.ts' because it would overwrite input file.

Solution

Add the following to internal-packages/database/tsconfig.json:

"include": ["src/**/*"]

This scopes the compiler's root input files to the source directory while preserving normal module resolution for imported files outside src, such as the generated Prisma client.

Testing

Verified locally using:

pnpm run dev --filter @trigger.dev/database

Before this change:

  • TS5055 was reported when starting TypeScript in watch mode.

After this change:

  • TypeScript starts successfully.
  • Watch mode initializes with Found 0 errors.

Notes

  • This change only affects the compiler's root input file selection.
  • No runtime behavior, build output, or package APIs are modified.
  • The change is limited to a single configuration file.

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 543692e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Hi @hardikkaurani, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Jul 27, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 216ae40e-fef4-44a8-af16-ad165631b191

📥 Commits

Reviewing files that changed from the base of the PR and between 4d8b5d6 and 543692e.

📒 Files selected for processing (1)
  • internal-packages/database/tsconfig.json

Walkthrough

Updated the database package TypeScript configuration to explicitly include files matching src/**/* for compilation and typechecking.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix/database-ts5055-windows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant