fix(database): restrict TypeScript root inputs to src - #4386
fix(database): restrict TypeScript root inputs to src#4386hardikkaurani wants to merge 1 commit into
Conversation
|
|
Hi @hardikkaurani, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the database package TypeScript configuration to explicitly include files matching ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR adds an explicit
includepattern tointernal-packages/database/tsconfig.jsonto restrict TypeScript root input files to thesrcdirectory.Problem
Running the following command on Windows:
starts TypeScript in watch mode with declaration output enabled. Since the package
tsconfig.jsondoes not explicitly define anincludepattern, the compiler may treat generated declaration files insidedist/as input files, resulting in the following error:Solution
Add the following to
internal-packages/database/tsconfig.json:This scopes the compiler's root input files to the source directory while preserving normal module resolution for imported files outside
src, such as the generated Prisma client.Testing
Verified locally using:
Before this change:
TS5055was reported when starting TypeScript in watch mode.After this change:
Found 0 errors.Notes