Skip to content

fix(webapp): fade overflowing side menu selector labels - #4412

Merged
samejr merged 4 commits into
mainfrom
samejr/org-menu-label-fade
Jul 29, 2026
Merged

fix(webapp): fade overflowing side menu selector labels#4412
samejr merged 4 commits into
mainfrom
samejr/org-menu-label-fade

Conversation

@samejr

@samejr samejr commented Jul 28, 2026

Copy link
Copy Markdown
Member

Long organization, project, and environment names in the side menu were cut off mid-character. They now fade out at the right edge like the rest of the side menu items already did.

Example of faded long names:

CleanShot 2026-07-28 at 22 59 24

The org, project, and environment selector rows each rendered their own plain
span, so long names hard-clipped mid-character (and the environment name ended
in an ellipsis). They now use SideMenuLabel, which masks the right edge only
while the text actually overflows, matching the rest of the menu.

The mask moved into a shared labelOverflowFade module so EnvironmentLabel can
reuse it; that component already measured overflow for its tooltip, so no
second observer was needed.
@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 337c1ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds a shared gradient-mask helper for right-edge label overflow. SideMenuLabel and EnvironmentLabel use the helper when text is clipped. Organization and project selector labels now use SideMenuLabel, while the environment selector removes its ellipsis class and documents fade behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too incomplete for the template; it lacks the issue reference, checklist, testing steps, changelog, and screenshots section. Add the required template sections: Closes #issue, checklist, testing performed, changelog, and a Screenshots section with concise details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and accurately summarizes the main change: fading overflowing selector labels in the webapp side menu.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/org-menu-label-fade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Un-export the mask constant (only used inside the module) and fold the
truncate check into the overflow argument.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@samejr
samejr merged commit a11e5ff into main Jul 29, 2026
33 checks passed
@samejr
samejr deleted the samejr/org-menu-label-fade branch July 29, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants