fix(build): support Playwright 1.58+ browser metadata - #4474
Conversation
🦋 Changeset detectedLatest commit: 8f29d27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @RealBhupesh, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe Playwright extension now recognizes both legacy browser metadata and Playwright 1.58 version-formatted metadata. New tests cover Chromium and Firefox selectors through the build-completion hook. A patch changeset documents corrected browser-binary installation for Playwright 1.58 and later deployments. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
browser:headers and the Playwright 1.58+(playwright <browser> v...)format.@trigger.dev/buildchangeset.Root cause
Playwright 1.58 changed the output of
playwright install --dry-run, so the previous grep no longer found browser metadata and download URLs.Validation
Please keep this PR in draft until vouching and CI review are complete.
refs #3924