Skip to content

fix(build): support Playwright 1.58+ browser metadata - #4474

Closed
RealBhupesh wants to merge 1 commit into
triggerdotdev:mainfrom
RealBhupesh:codex/trigger-3924-playwright
Closed

fix(build): support Playwright 1.58+ browser metadata#4474
RealBhupesh wants to merge 1 commit into
triggerdotdev:mainfrom
RealBhupesh:codex/trigger-3924-playwright

Conversation

@RealBhupesh

Copy link
Copy Markdown

Summary

  • Update the Playwright build extension to parse both legacy browser: headers and the Playwright 1.58+ (playwright <browser> v...) format.
  • Add regression coverage for Chromium and Firefox selectors.
  • Add the required @trigger.dev/build changeset.

Root cause

Playwright 1.58 changed the output of playwright install --dry-run, so the previous grep no longer found browser metadata and download URLs.

Validation

  • Targeted Playwright extension tests: 2 passed.
  • Formatting and lint checks passed.
  • Full package build is currently blocked by pre-existing missing generated workspace dependencies in this checkout.

Please keep this PR in draft until vouching and CI review are complete.

refs #3924

@changeset-bot

changeset-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8f29d27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/python Patch
@internal/dashboard-agent Patch
@trigger.dev/core Patch
@trigger.dev/react-hooks Patch
@trigger.dev/redis-worker Patch
@trigger.dev/rsc Patch
@trigger.dev/schema-to-json Patch
@trigger.dev/sdk Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
@trigger.dev/rbac Patch
@trigger.dev/sso Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/llm-model-catalog Patch
@internal/metrics-pipeline Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/run-store Patch
@internal/schedule-engine Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/tsql Patch
@internal/sdk-compat-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Hi @RealBhupesh, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Aug 2, 2026
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79dca699-965f-4411-a308-e9d8bcd42e20

📥 Commits

Reviewing files that changed from the base of the PR and between 14824b0 and 8f29d27.

📒 Files selected for processing (3)
  • .changeset/playwright-158-dry-run-parser.md
  • packages/build/src/extensions/playwright.test.ts
  • packages/build/src/extensions/playwright.ts

Walkthrough

The Playwright extension now recognizes both legacy browser metadata and Playwright 1.58 version-formatted metadata. New tests cover Chromium and Firefox selectors through the build-completion hook. A patch changeset documents corrected browser-binary installation for Playwright 1.58 and later deployments.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant