fix(core): stop custom metric exporters breaking the metrics export - #4613
Merged
Conversation
🦋 Changeset detectedLatest commit: a4af9bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
WalkthroughThe change adds an OpenTelemetry Collector test container and wires it into package tests. Buffered metrics now remove non-finite data points before export. Mergeability Score: ⚪ Minimal · up to The change serializes metric-reader flushing and filters non-finite values to prevent custom exporters from dropping entire metric batches; no actionable merge-blocking risk remains at the current head. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 94968072-156e-4862-9f4d-1d0f40cc24c2
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
.changeset/lucky-pillows-invite.md.github/workflows/unit-tests-packages.ymlinternal-packages/testcontainers/package.jsoninternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/utils.tspackages/core/package.jsonpackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/otel/tracingSDK.tspackages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/taskContext/otelProcessors.ts
💤 Files with no reviewable changes (1)
- internal-packages/testcontainers/package.json
📜 Review details
⏰ Context from checks skipped due to timeout. (31)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
- GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
- GitHub Check: sdk-compat / Bun Runtime
- GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: sdk-compat / Cloudflare Workers
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
- GitHub Check: runops-guard / runops-guard
- GitHub Check: sdk-compat / Deno Runtime
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (10)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
When adding Zod, use the exact repository-wide pinned version
3.25.76, never a different version or range.
Files:
packages/core/package.json
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
packages/core/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (packages/core/CLAUDE.md)
Never import the root package (
@trigger.dev/core). Always use subpath imports such as@trigger.dev/core/v3,@trigger.dev/core/v3/utils,@trigger.dev/core/logger, or@trigger.dev/core/schemas
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For public packages, use
buildfor verification.
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
packages/core/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Import
@trigger.dev/coresubpaths only; never import from the package root.
Files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/testcontainers/src/utils.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.ts
🧠 Learnings (12)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In this repo’s trigger.dev codebase, the “never mock — use testcontainers” guideline should only be applied to integration tests that talk to real external services (e.g., Redis, Postgres, S2). For unit tests that validate in-memory logic (e.g., deduplication/cache behavior in StandardRealtimeStreamsManager and similar module-boundary call counting), it is allowed to use Vitest mocks like `vi.fn()` and to stub/mock `ApiClient` objects to count calls or simulate in-process collaborators. Do not flag `vi.fn()`-based mocks as policy violations in these unit-test scenarios; reserve the rule for true external-service integration tests.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/taskContext/otelProcessors.tsinternal-packages/testcontainers/src/utils.tspackages/core/src/v3/otel/tracingSDK.test.tsinternal-packages/testcontainers/src/otelCollector.tsinternal-packages/testcontainers/src/index.tspackages/core/src/v3/taskContext/otelProcessors.test.tspackages/core/src/v3/otel/tracingSDK.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
packages/core/src/v3/otel/tracingSDKShutdown.test.tspackages/core/src/v3/otel/tracingSDK.test.tspackages/core/src/v3/taskContext/otelProcessors.test.ts
🔇 Additional comments (2)
packages/core/src/v3/otel/tracingSDK.ts (1)
103-103: LGTM!Also applies to: 322-322, 349-359
packages/core/src/v3/otel/tracingSDKShutdown.test.ts (1)
1-19: LGTM!
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
myftija
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Projects that configure their own
metricExportersormetricReadersintrigger.config.tswere losing task metrics on nearly every run, and seeing an unexplainedFailed to flush tracingSDKalongsideOTLPExporterError: Bad Requestin their run logs. Spans and logs kept working, so the runs otherwise looked healthy.Root cause and fix
Every configured exporter gets its own
PeriodicExportingMetricReader, andmeterProvider.forceFlush()fans out across all readers withPromise.all, so two collections can land on the same millisecond.@opentelemetry/host-metricsdivides by the elapsed interval to computeprocess.cpu.utilization(common.ts), so a zero interval yields0/0.JSON.stringify(NaN)isnull, and a collector rejects"asDouble": nullwith a 400 that drops the entire request, not just the offending point.flush()andshutdown()now walk the metric readers one at a time, so collections can no longer share a timestamp. Each reader is isolated, so one failing reader cannot skip the readers behind it, and every failure is logged with the reader that produced it. The first error is still rethrown, so callers see failures exactly as before.As a second layer, non-finite data points are dropped just before our own export, so a metric that divides by zero cannot take the rest of the batch with it. Exporters and readers supplied through
trigger.config.tsare untouched by that filter and still receive raw data.The trade-off is that configured exporters now flush after the built-in one rather than alongside it, so flush latency is the sum rather than the max.
An internal test package's dependency on core was replaced with a local helper, because core now needs that package in
devDependenciesand the two together formed a workspace cycle.Verification
Tested against a real collector in a container: a batch containing a
NaNreading is rejected with a 400 without the fix and accepted with it, and a single flush is asserted to collect from one reader at a time.