feat(supervisor): make the runner seccomp profile configurable - #4660
Conversation
|
WalkthroughThe supervisor adds configurable Kubernetes runner seccomp settings. The environment schema defines a profile path and runtime scope. Kubernetes pod creation passes these settings and checkpoint status to 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nicktrn
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6b02d50f-9d41-4c13-924a-8e46e7565e99
📒 Files selected for processing (4)
apps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: typecheck / typecheck
- GitHub Check: code-quality / code-quality
- GitHub Check: audit
- GitHub Check: audit
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when:
- Circular dependencies cannot be resolved otherwise
- Code splitting is genuinely needed for performance
- The module must be loaded conditionally at runtime
Zod is pinned to a single version across the entire monorepo (currently3.25.76). When adding zod to a new or existing package, use the exact same version as the rest of the repo - never a different version or a range. Mismatched zod versions cause runtime type incompatibilities (e.g., schemas from one package can't be used as body validators in another).
Do not reintroduce V1.
Add crumbs as you write code — not just when debugging.
Do not invent new namespaces — pick from this table or ask first.
Files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
We use vitest exclusively. Never mock anything - use testcontainers instead.
Files:
apps/supervisor/src/workloadManager/kubernetes.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
apps/supervisor/src/workloadManager/**/*
📄 CodeRabbit inference engine (apps/supervisor/CLAUDE.md)
Keep the Docker/Kubernetes container orchestration abstraction in
src/workloadManager/.
Files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/**/*.{ts,tsx}: - Apps and internal packages (apps/*,internal-packages/*): Usetypecheck. Never usebuildfor these — building proves almost nothing about correctness.
Always import from@trigger.dev/sdk. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Test files go next to source files (e.g.,
MyService.ts->MyService.test.ts).
Files:
apps/supervisor/src/workloadManager/kubernetes.test.ts
apps/supervisor/src/env.ts
📄 CodeRabbit inference engine (apps/supervisor/CLAUDE.md)
Keep environment configuration in
src/env.ts.
Files:
apps/supervisor/src/env.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.tsapps/supervisor/src/workloadManager/kubernetes.tsapps/supervisor/src/env.tsapps/supervisor/src/workloadManager/kubernetesPodSpec.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/supervisor/src/workloadManager/kubernetes.test.ts
🪛 OpenGrep (1.26.0)
apps/supervisor/src/workloadManager/kubernetesPodSpec.ts
[ERROR] 82-82: Dynamic command passed to child_process.exec/execSync. Use child_process.execFile or spawn with an argument array instead.
(coderabbit.command-injection.exec-js)
3 participants
Task pods on Kubernetes get their seccomp profile from a path hardcoded in the supervisor, applied only when the run's runtime is node-24 or newer. This makes both the path and the runtime scope configurable, so a cluster can update its profile and widen where it applies without a code change.
The runtime condition dates from the profile's original purpose: node-24+ always creates io_uring fds, which can't be checkpointed, so blocking
io_uring_setupmade libuv fall back to epoll. Older runtimes didn't need it.Configuration
KUBERNETES_RUNNER_SECCOMP_PROFILE_PATH- defaults toprofiles/block-io-uring.json, the path used before. Trimmed and non-empty, so a blank or whitespace-only value fails at startup rather than reaching pod creation as an invalid profile path.KUBERNETES_RUNNER_SECCOMP_PROFILE_RUNTIMES-none|node-24-plus|all, defaulting tonode-24-plus.Both defaults reproduce current behaviour exactly, so merging changes nothing. Widening to every runtime, or turning attachment off entirely, is a config change rather than a deploy.
bundoesn't match the node version pattern, so it picks up the profile only underall.Why the runtime scope stays
The profile is a node-local file installed outside this repo, and a
Localhostprofile whose file is missing fails pod creation. Undernode-24-plusa node without the file breaks only node-24+ runs; underallit would break every run on that node. Keeping the narrower default means widening is a deliberate step taken once the profile is known to be present fleet-wide, rather than a side effect of this PR.Attachment also stays behind the existing checkpoints condition, so an install that doesn't configure checkpointing is unaffected.
Shape
Every condition - checkpoints, scope, runtime match - now lives inside
withRunnerSeccompProfile, so the call site is a single call with no branching.Tests
The scope matrix is covered: node-24+ and older runtimes under
node-24-plus, every runtime underall, nothing undernone, and nothing when checkpoints are disabled. Full supervisor suite: 251 passed, 22 skipped.No changeset or
.server-changes: defaults preserve current behaviour, so there is nothing for a user to act on.