Skip to content

✨ Added config to specify custom adapter install location#29487

Merged
acburdine merged 1 commit into
mainfrom
feat/adapters-custom-path
Jul 21, 2026
Merged

✨ Added config to specify custom adapter install location#29487
acburdine merged 1 commit into
mainfrom
feat/adapters-custom-path

Conversation

@acburdine

Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/PLA-249

  • in custom Ghost docker builds, adapters installed in the default content dir are potentially susceptible to shadowing if the content dir is bind-mounted into the container
  • adding a separate 'installedAdaptersPath' config option allows specifying a directory inside the container build where adapters can be installed

Long-term it may make sense to deprecate the content/adapters path (esp in Docker installs) but for now this unblocks custom adapter installs.

ref https://linear.app/ghost/issue/PLA-249
- in custom Ghost docker builds, adapters installed in the default `content` dir are potentially susceptible to shadowing if the `content` dir is bind-mounted into the container
- adding a separate 'installedAdaptersPath' config option allows specifying a directory inside the container build where adapters can be installed
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: be27cd24-2772-4737-b03a-d223ccbf1863

📥 Commits

Reviewing files that changed from the base of the PR and between 6217048 and a361e47.

📒 Files selected for processing (1)
  • ghost/core/core/server/services/adapter-manager/index.ts

Walkthrough

The adapter manager now builds its lookup paths with a Set<string>, retaining the existing node_modules, content adapters, and internal adapter locations while adding the optional configured installed adapters path. The resulting set is converted to an array when constructing the singleton AdapterManager.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding a configurable adapter install location.
Description check ✅ Passed The description is clearly about the new installedAdaptersPath config and its Docker build use case.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/adapters-custom-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine requested review from 9larsons and vershwal July 21, 2026 11:46
@nx-cloud

nx-cloud Bot commented Jul 21, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit a361e47

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 2m 24s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 10s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 2s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 38s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 26s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 14s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 16s View ↗
nx run @tryghost/admin:build ✅ Succeeded 4s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-21 11:55:24 UTC

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (6217048) to head (a361e47).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29487      +/-   ##
==========================================
- Coverage   74.59%   74.56%   -0.04%     
==========================================
  Files        1604     1604              
  Lines      140906   140913       +7     
  Branches    17202    17202              
==========================================
- Hits       105108   105068      -40     
- Misses      34740    34789      +49     
+ Partials     1058     1056       -2     
Flag Coverage Δ
e2e-tests 76.64% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acburdine
acburdine merged commit 9534ef0 into main Jul 21, 2026
50 checks passed
@acburdine
acburdine deleted the feat/adapters-custom-path branch July 21, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant