Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #1981

@benjeffery benjeffery marked this pull request as ready for review January 10, 2022 17:15
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2086 (fe72192) into main (eae961c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2086   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          27       27           
  Lines       25557    25561    +4     
  Branches     1159     1159           
=======================================
+ Hits        23866    23870    +4     
  Misses       1660     1660           
  Partials       31       31           
Flag Coverage Δ
c-tests 92.38% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 72.16% <75.00%> (+<0.01%) ⬆️
python-tests 98.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/util.py 100.00% <ø> (ø)
python/tskit/tables.py 98.77% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 98.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae961c...fe72192. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 295a92d into tskit-dev:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename TableCollection.name_map to table_name_map and deprecate

2 participants