Skip to content

Conversation

@benjeffery
Copy link
Member

Fixes #2161

@benjeffery
Copy link
Member Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2022

rebase

❌ Base branch update has failed

err-code: 2C9DD

@benjeffery benjeffery force-pushed the variant-site-struct branch from 464ddf8 to 7daef06 Compare March 17, 2022 22:20
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2162 (7daef06) into main (2983da8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
+ Coverage   93.28%   93.29%   +0.01%     
==========================================
  Files          27       27              
  Lines       25897    25891       -6     
  Branches     1163     1163              
==========================================
- Hits        24157    24154       -3     
+ Misses       1710     1707       -3     
  Partials       30       30              
Flag Coverage Δ
c-tests 92.19% <100.00%> (+0.02%) ⬆️
lwt-tests 89.05% <ø> (ø)
python-c-tests 72.10% <100.00%> (ø)
python-tests 98.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/genotypes.c 89.59% <100.00%> (+0.78%) ⬆️
python/_tskitmodule.c 90.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2983da8...7daef06. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that's a definite win, thanks.

@mergify mergify bot merged commit d509e8e into tskit-dev:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store site in tsk_variant_t struct

2 participants