-
Notifications
You must be signed in to change notification settings - Fork 78
use min_time to allow negative times in ts #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2215 +/- ##
==========================================
- Coverage 93.28% 93.27% -0.01%
==========================================
Files 28 28
Lines 26385 26425 +40
Branches 1188 1196 +8
==========================================
+ Hits 24612 24649 +37
- Misses 1743 1744 +1
- Partials 30 32 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c9120f3 to
b4a893e
Compare
benjeffery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @hyanwong.
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, spotted a few small issues and some structuring suggestions.
|
is this ready to go @hyanwong ? |
|
I made the changes you suggested, so yes, I think so. |
Fixes #2197