Skip to content

Conversation

@hyanwong
Copy link
Member

Fixes #2197

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2215 (2ea6dd0) into main (f4b8dcb) will decrease coverage by 0.00%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
- Coverage   93.28%   93.27%   -0.01%     
==========================================
  Files          28       28              
  Lines       26385    26425      +40     
  Branches     1188     1196       +8     
==========================================
+ Hits        24612    24649      +37     
- Misses       1743     1744       +1     
- Partials       30       32       +2     
Flag Coverage Δ
c-tests 92.30% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.52% <13.51%> (-0.14%) ⬇️
python-tests 98.85% <98.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.14% <ø> (ø)
python/tskit/drawing.py 99.17% <98.66%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b8dcb...2ea6dd0. Read the comment docs.

@hyanwong hyanwong force-pushed the neg-time-svg branch 2 times, most recently from c9120f3 to b4a893e Compare April 27, 2022 08:58
Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hyanwong.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, spotted a few small issues and some structuring suggestions.

@jeromekelleher
Copy link
Member

is this ready to go @hyanwong ?

@hyanwong
Copy link
Member Author

hyanwong commented Jun 7, 2022

I made the changes you suggested, so yes, I think so.

@mergify mergify bot merged commit bf5f440 into tskit-dev:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Draw SVG broken for trees with negative node times

3 participants