Sackin C implementation #2258
Merged
Sackin C implementation #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sigh - codecov has gone a bit haywire again. I think everything that can be covered is covered. |
Member
Author
|
Bumping this one @benjeffery |
benjeffery
approved these changes
May 16, 2022
Member
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
LGTM - One question, is a 32bit depth only safe when _TSK_BIG_TABLES is not used? I'm not sure how paranoid to be here, but maybe the type of depth should be conditional on that macro?
+ Python/C glue for sackin_index Closes tskit-dev#2253
Member
Author
Hah, good spot. I changed the depth value to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the C testing framework for the rest of the balance metrics. So, to implement other balance metrics in C we add the implementation, and then test the returned value in these three test function.
cc @jeremyguez