Avoid copy in tsk_treeseq_simplify

[jeromekelleher]

Closes #2287

[codecov]

Codecov Report

Merging #2288 (afed65a) into main (7740baa) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
- Coverage   93.33%   93.33%   -0.01%     
==========================================
  Files          27       27              
  Lines       26134    26141       +7     
  Branches     1175     1175              
==========================================
+ Hits        24393    24398       +5     
- Misses       1711     1713       +2     
  Partials       30       30              

Flag	Coverage Δ
c-tests	92.30% <81.81%> (-0.02%)	⬇️
lwt-tests	89.05% <ø> (ø)
python-c-tests	71.88% <ø> (ø)
python-tests	98.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
c/tskit/trees.c	95.23% <81.81%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7740baa...afed65a. Read the comment docs.

[benjeffery]

LGTM! Great!

[petrelharp]

Whoah, this is very nice. This should help SLiM, @bhaller! (once I merge the final tskit C_1.0 in).

[bhaller]

Whoah, this is very nice. This should help SLiM, @bhaller! (once I merge the final tskit C_1.0 in).

Nice! I wasn't aware this was happening, looks helpful indeed.

[jeromekelleher]

This should help SLiM, @bhaller! (once I merge the final tskit C_1.0 in).

I'd be surprised if it makes any difference for SLiM, since I'd imagine you guys are calling tsk_table_collection_simplify rather than tsk_treeseq_simplify.

[bhaller]

This should help SLiM, @bhaller! (once I merge the final tskit C_1.0 in).

I'd be surprised if it makes any difference for SLiM, since I'd imagine you guys are calling tsk_table_collection_simplify rather than tsk_treeseq_simplify.

Ah! That is true, we are.