Skip to content

Conversation

@jeromekelleher
Copy link
Member

Missing data in VCF and other tweaks.

@jeromekelleher jeromekelleher marked this pull request as ready for review June 9, 2022 11:55
@jeromekelleher jeromekelleher requested a review from benjeffery June 9, 2022 11:56
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2329 (f75cc45) into main (2a7341c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          28       28           
  Lines       26480    26482    +2     
  Branches     1210     1211    +1     
=======================================
+ Hits        24704    24706    +2     
  Misses       1744     1744           
  Partials       32       32           
Flag Coverage Δ
c-tests 92.31% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.35% <8.33%> (-0.02%) ⬇️
python-tests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.17% <100.00%> (ø)
python/tskit/vcf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7341c...f75cc45. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit a9082d0 into tskit-dev:main Jun 9, 2022
@jeromekelleher jeromekelleher deleted the vcf-updates branch June 9, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants