Skip to content

Conversation

@jeromekelleher
Copy link
Member

Finishing touches for Colless index

cc @jeremyguez

@jeromekelleher jeromekelleher marked this pull request as ready for review June 16, 2022 11:56
Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the compiler isn't happy in 64bit mode though.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #2344 (3099d09) into main (3e61a10) will decrease coverage by 0.02%.
The diff coverage is 84.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   93.29%   93.27%   -0.03%     
==========================================
  Files          28       28              
  Lines       26730    26768      +38     
  Branches     1222     1217       -5     
==========================================
+ Hits        24939    24969      +30     
- Misses       1758     1766       +8     
  Partials       33       33              
Flag Coverage Δ
c-tests 92.25% <92.50%> (+<0.01%) ⬆️
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.46% <53.84%> (+0.06%) ⬆️
python-tests 98.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/core.h 100.00% <ø> (ø)
python/_tskitmodule.c 90.68% <58.33%> (-0.06%) ⬇️
c/tskit/trees.c 95.04% <91.17%> (-0.05%) ⬇️
c/tskit/core.c 97.93% <100.00%> (+0.01%) ⬆️
python/tskit/trees.py 98.27% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e61a10...3099d09. Read the comment docs.

@mergify mergify bot merged commit a1b1e5d into tskit-dev:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants